go/sliding-sync
go/sliding-sync
1
0
Fork 0
mirror of https://github.com/matrix-org/sliding-sync.git synced 2025-03-10 13:37:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

bugfix: ensure we don't append nothing else we can end up with null arrays

Browse Source 
Caught by element-web cypress tests, which consistently failed.
This commit is contained in:
Kegan Dougal 2023-02-10 14:02:21 +00:00
parent c063352508
commit 3c964de004
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sync3/extensions/account_data.go
View File

@ -53,10 +53,12 @@ func (r *AccountDataRequest) AppendLive(ctx context.Context, res *Response, extC
if err != nil {
logger.Err(err).Str("user", extCtx.UserID).Str("room", update.RoomID()).Msg("failed to fetch room account data")
} else {
if len(roomAccountData) > 0 { // else we can end up with `null` not `[]`
roomToMsgs[update.RoomID()] = accountEventsAsJSON(roomAccountData)
}
}
}
}
if len(globalMsgs) == 0 && len(roomToMsgs) == 0 {
return
}