go/sliding-sync
go/sliding-sync
1
0
Fork 0
mirror of https://github.com/matrix-org/sliding-sync.git synced 2025-03-10 13:37:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Return M_UNKNOWN_TOKEN for unknown tokens

Browse Source
This commit is contained in:
Kegan Dougal 2023-08-15 14:33:48 +01:00
parent 2a2dcbe145
commit 540310ba5e
2 changed files with 34 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sync3/handler/handler.go
View File

@ -431,6 +431,7 @@ func (h *SyncLiveHandler) identifyUnknownAccessToken(accessToken string, logger
return nil, &internal.HandlerError{
StatusCode: 401,
Err: fmt.Errorf("/whoami returned HTTP 401"),
ErrCode: "M_UNKNOWN_TOKEN",
}
}
log.Warn().Err(err).Msg("failed to get user ID from device ID")

34
tests-integration/token_management_test.go
View File

@ -3,17 +3,49 @@ package syncv3
import (
"context"
"encoding/json"
"github.com/tidwall/gjson"
"net/http"
"testing"
"time"
"github.com/tidwall/gjson"
"github.com/matrix-org/sliding-sync/sync2"
"github.com/matrix-org/sliding-sync/sync3"
"github.com/matrix-org/sliding-sync/testutils"
"github.com/matrix-org/sliding-sync/testutils/m"
)
func TestInvalidTokenReturnsMUnknownTokenError(t *testing.T) {
pqString := testutils.PrepareDBConnectionString()
v2 := runTestV2Server(t)
v3 := runTestServer(t, v2, pqString)
defer v2.close()
defer v3.close()
_, respBytes, statusCode := v3.doV3Request(t, context.Background(), "invalid_token", "", sync3.Request{
Lists: map[string]sync3.RequestList{
"a": {
Ranges: sync3.SliceRanges{{0, 1}},
},
},
})
if statusCode != 401 {
t.Errorf("got HTTP %v want 401", statusCode)
}
var jsonError struct {
Err string `json:"error"`
ErrCode string `json:"errcode"`
}
if err := json.Unmarshal(respBytes, &jsonError); err != nil {
t.Fatalf("failed to unmarshal error response into JSON: %v", string(respBytes))
}
wantErrCode := "M_UNKNOWN_TOKEN"
if jsonError.ErrCode != wantErrCode {
t.Errorf("errcode: got %v want %v", jsonError.ErrCode, wantErrCode)
}
}
func TestSyncWithNewTokenAfterOldExpires(t *testing.T) {
pqString := testutils.PrepareDBConnectionString()
v2 := runTestV2Server(t)