Review comments

.github/workflows/tests.yml

@@ -45,7 +45,7 @@ jobs:
             - name: Install Go
               uses: actions/setup-go@v4
               with:
-                  go-version: 1.20
+                  go-version: "1.20"
 
             - name: Build
               run: go build ./cmd/syncv3
@@ -130,7 +130,7 @@ jobs:
             - name: Install Go
               uses: actions/setup-go@v4
               with:
-                go-version: 1.20
+                go-version: "1.20"
 
             - name: Build
               run: go build ./cmd/syncv3
@@ -260,7 +260,7 @@ jobs:
           - name: Install Go
             uses: actions/setup-go@v4
             with:
-              go-version: 1.20
+              go-version: "1.20"
 
           # E2E tests with ${{env.PREV_VERSION}}
           - uses: actions/checkout@v3

state/accumulator.go

@@ -238,6 +238,7 @@ func (a *Accumulator) Initialise(roomID string, state []json.RawMessage) (Initia
 				Str("room_id", roomID).
 				Int("len_state", len(events)).
 				Msg(errMsg)
+			// the HS gave us bad data so there's no point retrying => return DataError
 			return internal.NewDataError(errMsg)
 		}
 
@@ -389,6 +390,7 @@ func (a *Accumulator) Accumulate(txn *sqlx.Tx, userID, roomID string, prevBatch
 				})
 				sentry.CaptureMessage(msg)
 			})
+			// the HS gave us bad data so there's no point retrying
 			// by not returning an error, we are telling the poller it is fine to not retry this request.
 			return 0, nil, nil
 		}