go/sliding-sync
go/sliding-sync
1
0
Fork 0
mirror of https://github.com/matrix-org/sliding-sync.git synced 2025-03-10 13:37:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure the create event is present if there is no state and no snapshot

Browse Source
This commit is contained in:
Kegan Dougal 2023-08-14 18:31:19 +01:00
parent 3c9ebdf358
commit 8c7046e96b
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
state/accumulator.go
View File

@ -198,6 +198,20 @@ func (a *Accumulator) ProcessRoomEvents(userID, roomID string, timeline, state [
return nil
}
// if there is no existing snapshot AND there is no state block, then timeline[0] MUST be the create event, else we
// are seemingly getting random events without being told the room state. Whine loudly in sentry about it.
// We hypothesise that these events happen when a slow server finally sends some events to the upstream HS after a
// period of downtime. _When those events were sent_ the user was in the room, but now they are not, and /sync just
// blindly chucks them down anyway.
if snapID == 0 && gjson.ParseBytes(timeline[0]).Get("type").Str != "m.room.create" {
err := fmt.Errorf(
"ProcessRoomEvents: no state block, no existing snapID, and timeline[0] isn't m.room.create, did we just get pushed random events? room=%s user=%s len(timeline)=%d",
roomID, userID, len(timeline),
)
sentry.CaptureException(err)
return err
}
// Insert the event JSON
eventIDToNID, err := a.eventsTable.Insert(txn, dedupedEvents, false)
if err != nil {