go/sliding-sync
go/sliding-sync
1
0
Fork 0
mirror of https://github.com/matrix-org/sliding-sync.git synced 2025-03-10 13:37:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

client: bugfix which resulted in dupe rooms

Browse Source
This commit is contained in:
Kegan Dougal 2022-01-04 16:47:56 +00:00
parent 8f27160a88
commit eaa6593d36
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
client/index.js
View File

@ -475,20 +475,23 @@ const doSyncLoop = async (accessToken, sessionId) => {
});
// TODO: clear gapIndex immediately after next op to avoid a genuine DELETE shifting incorrectly e.g leaving a room
// TODO: namespace gapIndex per list index
let gapIndex = -1;
let gapIndexes = {};
resp.counts.forEach((count, index) => {
gapIndexes[index] = -1;
});
resp.ops.forEach((op) => {
if (op.op === "DELETE") {
console.log("DELETE", op.list, op.index, ";");
delete activeLists[op.list].roomIndexToRoomId[op.index];
gapIndex = op.index;
gapIndexes[op.list] = op.index;
} else if (op.op === "INSERT") {
console.log("INSERT", op.list, op.index, op.room.room_id, ";");
if (activeLists[op.list].roomIndexToRoomId[op.index]) {
const gapIndex = gapIndexes[op.list];
// something is in this space, shift items out of the way
if (gapIndex < 0) {
console.log(
"cannot work out where gap is, INSERT without previous DELETE!"
"cannot work out where gap is, INSERT without previous DELETE! List: ", op.list,
);
return;
}