Remove obsolete TxData.tags and make TxData.events non-optional

This commit is contained in:
Simon Warta 2020-09-21 12:47:36 +02:00
parent e499b46bfd
commit 63082a9e85
5 changed files with 10 additions and 18 deletions

View File

@ -54,6 +54,8 @@
is always set.
- @cosmjs/tendermint-rpc: Change type of `GenesisResponse.appState` to
`Record<string, unknown> | undefined`.
- @cosmjs/tendermint-rpc: Remove obsolete `TxData.tags` and make `TxData.events`
non-optional.
- @cosmjs/utils: Add `assertDefined`.
- @cosmjs/faucet: Rename binary from `cosmwasm-faucet` to `cosmos-faucet`.

View File

@ -485,6 +485,7 @@ function websocketTestSuite(rpcFactory: () => RpcClient, adaptor: Adaptor, appCr
expect(event.height).toBeGreaterThan(0);
expect(event.index).toEqual(0);
expect(event.result).toBeTruthy();
expect(event.result.events.length).toBeGreaterThanOrEqual(1);
events.push(event);
@ -507,12 +508,7 @@ function websocketTestSuite(rpcFactory: () => RpcClient, adaptor: Adaptor, appCr
expect(events.length).toEqual(2);
// Meta
expect(events[1].height).toEqual(events[0].height + 1);
if (events[1].result.tags && events[0].result.tags) {
expect(events[1].result.tags).not.toEqual(events[0].result.tags);
}
if (events[1].result.events && events[0].result.events) {
expect(events[1].result.events).not.toEqual(events[0].result.events);
}
expect(events[1].result.events).not.toEqual(events[0].result.events);
// Content
expect(events[0].tx).toEqual(transactionData1);
expect(events[1].tx).toEqual(transactionData2);
@ -536,6 +532,7 @@ function websocketTestSuite(rpcFactory: () => RpcClient, adaptor: Adaptor, appCr
expect(event.height).toBeGreaterThan(0);
expect(event.index).toEqual(0);
expect(event.result).toBeTruthy();
expect(event.result.events.length).toBeGreaterThanOrEqual(1);
events.push(event);
if (events.length === 2) {
@ -554,12 +551,7 @@ function websocketTestSuite(rpcFactory: () => RpcClient, adaptor: Adaptor, appCr
expect(events.length).toEqual(2);
// Meta
expect(events[1].height).toEqual(events[0].height + 1);
if (events[1].result.tags && events[0].result.tags) {
expect(events[1].result.tags).not.toEqual(events[0].result.tags);
}
if (events[1].result.events && events[0].result.events) {
expect(events[1].result.events).not.toEqual(events[0].result.events);
}
expect(events[1].result.events).not.toEqual(events[0].result.events);
// Content
expect(events[0].tx).toEqual(transactionData1);
expect(events[1].tx).toEqual(transactionData2);

View File

@ -177,8 +177,7 @@ export interface TxData {
readonly code: number;
readonly log?: string;
readonly data?: Uint8Array;
readonly tags?: readonly Tag[];
readonly events?: readonly Event[];
readonly events: readonly Event[];
// readonly fees?: any;
}

View File

@ -126,7 +126,7 @@ interface RpcTxData {
readonly code?: number;
readonly log?: string;
readonly data?: Base64String;
readonly events?: readonly RpcEvent[];
readonly events: readonly RpcEvent[];
}
function decodeTxData(data: RpcTxData): responses.TxData {
@ -134,7 +134,7 @@ function decodeTxData(data: RpcTxData): responses.TxData {
data: may(Base64.decode, data.data),
log: data.log,
code: Integer.parse(assertNumber(optional<number>(data.code, 0))),
events: may(decodeEvents, data.events),
events: decodeEvents(data.events),
};
}

View File

@ -138,8 +138,7 @@ export interface TxData {
readonly code: number;
readonly log?: string;
readonly data?: Uint8Array;
readonly tags?: readonly Tag[];
readonly events?: readonly Event[];
readonly events: readonly Event[];
}
export interface TxProof {
readonly data: Uint8Array;