diff --git a/packages/tendermint-rpc/src/tendermint34/responses.ts b/packages/tendermint-rpc/src/tendermint34/responses.ts index ed38c9154d..c9d1ec41ac 100644 --- a/packages/tendermint-rpc/src/tendermint34/responses.ts +++ b/packages/tendermint-rpc/src/tendermint34/responses.ts @@ -325,6 +325,9 @@ export interface NodeInfo { /** IP and port */ readonly listenAddr: string; readonly network: string; + /** + * The Tendermint version. Can be empty (see https://github.com/cosmos/cosmos-sdk/issues/7963). + */ readonly version: string; readonly channels: string; // ??? readonly moniker: string; diff --git a/packages/tendermint-rpc/src/tendermint35/responses.ts b/packages/tendermint-rpc/src/tendermint35/responses.ts index c18bd9d360..d1e9f5a8e2 100644 --- a/packages/tendermint-rpc/src/tendermint35/responses.ts +++ b/packages/tendermint-rpc/src/tendermint35/responses.ts @@ -330,6 +330,9 @@ export interface NodeInfo { /** IP and port */ readonly listenAddr: string; readonly network: string; + /** + * The Tendermint version. Can be empty (see https://github.com/cosmos/cosmos-sdk/issues/7963). + */ readonly version: string; readonly channels: string; // ??? readonly moniker: string; diff --git a/packages/tendermint-rpc/src/testutil.spec.ts b/packages/tendermint-rpc/src/testutil.spec.ts index 714a02ad83..6ecdec887f 100644 --- a/packages/tendermint-rpc/src/testutil.spec.ts +++ b/packages/tendermint-rpc/src/testutil.spec.ts @@ -5,8 +5,8 @@ export const anyMatcher = /^.*$/; // Any string, including empty. Does not do mo export interface ExpectedValues { /** The Tendermint version as reported by Tendermint itself */ - readonly version: string | RegExp; - readonly chainId: string | RegExp; + readonly version: RegExp; + readonly chainId: RegExp; readonly appCreator: string; readonly p2pVersion: number; readonly blockVersion: number; @@ -41,7 +41,7 @@ export const tendermintInstances = { blockTime: 500, expected: { chainId: /^[-a-zA-Z0-9]{3,30}$/, - version: anyMatcher, + version: /^$/, // Unfortunately we don't get info here appCreator: "Cosmoshi Netowoko", p2pVersion: 8, blockVersion: 11, @@ -53,8 +53,8 @@ export const tendermintInstances = { version: "0.35.x", blockTime: 500, expected: { - chainId: "dockerchain", - version: anyMatcher, + chainId: /^dockerchain$/, + version: /^$/, // Unfortunately we don't get info here appCreator: "Cosmoshi Netowoko", p2pVersion: 8, blockVersion: 11,