mjs/cosmjs
mjs/cosmjs
1
0
Fork 0
mirror of https://github.com/cosmos/cosmjs.git synced 2025-03-11 14:09:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve type checks of RequestParser.parseCreditBody

Browse Source
This commit is contained in:
Simon Warta 2020-08-04 11:23:29 +02:00
parent 8bb2b1bb76
commit 7dfdec3da3
2 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/faucet/src/api/requestparser.spec.ts
View File

@ -7,6 +7,18 @@ describe("RequestParser", () => {
});
it("throws for invalid credit requests", () => {
// body not a dictionary
{
expect(() => RequestParser.parseCreditBody("foo")).toThrowError(/Request body must be a dictionary./i);
expect(() => RequestParser.parseCreditBody(null)).toThrowError(/Request body must be a dictionary./i);
expect(() => RequestParser.parseCreditBody(42)).toThrowError(/Request body must be a dictionary./i);
expect(() => RequestParser.parseCreditBody([])).toThrowError(/Request body must be a dictionary./i);
expect(() => RequestParser.parseCreditBody(true)).toThrowError(/Request body must be a dictionary./i);
expect(() => RequestParser.parseCreditBody(undefined)).toThrowError(
/Request body must be a dictionary./i,
);
}
// address unset
{
const body = { ticker: "TKN" };

10
packages/faucet/src/api/requestparser.ts
View File

@ -1,3 +1,5 @@
import { isNonNullObject } from "@cosmjs/utils";
import { HttpError } from "./httperror";
export interface CreditRequestBodyData {
@ -8,8 +10,12 @@ export interface CreditRequestBodyData {
}
export class RequestParser {
public static parseCreditBody(body: any): CreditRequestBodyData {
const { address, ticker } = body;
public static parseCreditBody(body: unknown): CreditRequestBodyData {
if (!isNonNullObject(body) || Array.isArray(body)) {
throw new HttpError(400, "Request body must be a dictionary.");
}
const { address, ticker } = body as any;
if (typeof address !== "string") {
throw new HttpError(400, "Property 'address' must be a string.");