From 80d75d79dbd1ad114266c3f9fbb680699e9f41df Mon Sep 17 00:00:00 2001 From: Simon Warta Date: Tue, 20 Jul 2021 15:20:34 +0200 Subject: [PATCH] Enable noImplicitOverride and adapt code --- packages/cosmwasm-launchpad/src/cw1cosmwasmclient.ts | 2 +- packages/cosmwasm-launchpad/src/cw3cosmwasmclient.ts | 2 +- packages/cosmwasm-launchpad/src/signingcosmwasmclient.ts | 4 ++-- packages/cosmwasm-stargate/src/testutils.spec.ts | 8 ++++---- packages/crypto/src/secp256k1signature.ts | 4 ++-- packages/launchpad/src/signingcosmosclient.ts | 4 ++-- packages/stargate/src/testutils.spec.ts | 8 ++++---- tsconfig.json | 1 + 8 files changed, 17 insertions(+), 16 deletions(-) diff --git a/packages/cosmwasm-launchpad/src/cw1cosmwasmclient.ts b/packages/cosmwasm-launchpad/src/cw1cosmwasmclient.ts index 8790e4b980..2fd8598878 100644 --- a/packages/cosmwasm-launchpad/src/cw1cosmwasmclient.ts +++ b/packages/cosmwasm-launchpad/src/cw1cosmwasmclient.ts @@ -20,7 +20,7 @@ export class Cw1CosmWasmClient extends SigningCosmWasmClient { this.cw1ContractAddress = cw1ContractAddress; } - public async getAccount(address?: string): Promise { + public override async getAccount(address?: string): Promise { return super.getAccount(address || this.cw1ContractAddress); } diff --git a/packages/cosmwasm-launchpad/src/cw3cosmwasmclient.ts b/packages/cosmwasm-launchpad/src/cw3cosmwasmclient.ts index 226e049e16..8799eb1823 100644 --- a/packages/cosmwasm-launchpad/src/cw3cosmwasmclient.ts +++ b/packages/cosmwasm-launchpad/src/cw3cosmwasmclient.ts @@ -84,7 +84,7 @@ export class Cw3CosmWasmClient extends SigningCosmWasmClient { this.cw3ContractAddress = cw3ContractAddress; } - public getAccount(address?: string): Promise { + public override getAccount(address?: string): Promise { return super.getAccount(address || this.cw3ContractAddress); } diff --git a/packages/cosmwasm-launchpad/src/signingcosmwasmclient.ts b/packages/cosmwasm-launchpad/src/signingcosmwasmclient.ts index 34d3f579a0..971d5099ac 100644 --- a/packages/cosmwasm-launchpad/src/signingcosmwasmclient.ts +++ b/packages/cosmwasm-launchpad/src/signingcosmwasmclient.ts @@ -184,11 +184,11 @@ export class SigningCosmWasmClient extends CosmWasmClient { this.fees = buildFeeTable(gasPrice, defaultGasLimits, gasLimits); } - public async getSequence(address?: string): Promise { + public override async getSequence(address?: string): Promise { return super.getSequence(address || this.signerAddress); } - public async getAccount(address?: string): Promise { + public override async getAccount(address?: string): Promise { return super.getAccount(address || this.signerAddress); } diff --git a/packages/cosmwasm-stargate/src/testutils.spec.ts b/packages/cosmwasm-stargate/src/testutils.spec.ts index a8f37eac1b..7bd7307a88 100644 --- a/packages/cosmwasm-stargate/src/testutils.spec.ts +++ b/packages/cosmwasm-stargate/src/testutils.spec.ts @@ -204,7 +204,7 @@ export async function makeWasmClient( * A class for testing clients using an Amino signer which modifies the transaction it receives before signing */ export class ModifyingSecp256k1HdWallet extends Secp256k1HdWallet { - public static async fromMnemonic( + public static override async fromMnemonic( mnemonic: string, options: Partial = {}, ): Promise { @@ -213,7 +213,7 @@ export class ModifyingSecp256k1HdWallet extends Secp256k1HdWallet { return new ModifyingSecp256k1HdWallet(mnemonicChecked, { ...options, seed: seed }); } - public async signAmino(signerAddress: string, signDoc: StdSignDoc): Promise { + public override async signAmino(signerAddress: string, signDoc: StdSignDoc): Promise { const modifiedSignDoc = { ...signDoc, fee: { @@ -230,7 +230,7 @@ export class ModifyingSecp256k1HdWallet extends Secp256k1HdWallet { * A class for testing clients using a direct signer which modifies the transaction it receives before signing */ export class ModifyingDirectSecp256k1HdWallet extends DirectSecp256k1HdWallet { - public static async fromMnemonic( + public static override async fromMnemonic( mnemonic: string, options: Partial = {}, ): Promise { @@ -239,7 +239,7 @@ export class ModifyingDirectSecp256k1HdWallet extends DirectSecp256k1HdWallet { return new ModifyingDirectSecp256k1HdWallet(mnemonicChecked, { ...options, seed: seed }); } - public async signDirect(address: string, signDoc: SignDoc): Promise { + public override async signDirect(address: string, signDoc: SignDoc): Promise { const txBody = TxBody.decode(signDoc.bodyBytes); const modifiedTxBody = TxBody.fromPartial({ ...txBody, diff --git a/packages/crypto/src/secp256k1signature.ts b/packages/crypto/src/secp256k1signature.ts index be10f02645..dbf9eca12a 100644 --- a/packages/crypto/src/secp256k1signature.ts +++ b/packages/crypto/src/secp256k1signature.ts @@ -145,7 +145,7 @@ export class ExtendedSecp256k1Signature extends Secp256k1Signature { * Decode extended signature from the simple fixed length encoding * described in toFixedLength(). */ - public static fromFixedLength(data: Uint8Array): ExtendedSecp256k1Signature { + public static override fromFixedLength(data: Uint8Array): ExtendedSecp256k1Signature { if (data.length !== 65) { throw new Error(`Got invalid data length ${data.length}. Expected 32 + 32 + 1`); } @@ -177,7 +177,7 @@ export class ExtendedSecp256k1Signature extends Secp256k1Signature { * r (32 bytes) | s (32 bytes) | recovery param (1 byte) * where | denotes concatenation of bonary data. */ - public toFixedLength(): Uint8Array { + public override toFixedLength(): Uint8Array { return new Uint8Array([...this.r(32), ...this.s(32), this.recovery]); } } diff --git a/packages/launchpad/src/signingcosmosclient.ts b/packages/launchpad/src/signingcosmosclient.ts index 125807ecc7..b1e5f877f1 100644 --- a/packages/launchpad/src/signingcosmosclient.ts +++ b/packages/launchpad/src/signingcosmosclient.ts @@ -57,11 +57,11 @@ export class SigningCosmosClient extends CosmosClient { this.fees = buildFeeTable(gasPrice, defaultGasLimits, gasLimits); } - public async getSequence(address?: string): Promise { + public override async getSequence(address?: string): Promise { return super.getSequence(address || this.signerAddress); } - public async getAccount(address?: string): Promise { + public override async getAccount(address?: string): Promise { return super.getAccount(address || this.signerAddress); } diff --git a/packages/stargate/src/testutils.spec.ts b/packages/stargate/src/testutils.spec.ts index 3f0e17d1ff..dc7e973b28 100644 --- a/packages/stargate/src/testutils.spec.ts +++ b/packages/stargate/src/testutils.spec.ts @@ -157,7 +157,7 @@ export const tendermintIdMatcher = /^[0-9A-F]{64}$/; * A class for testing clients using an Amino signer which modifies the transaction it receives before signing */ export class ModifyingSecp256k1HdWallet extends Secp256k1HdWallet { - public static async fromMnemonic( + public static override async fromMnemonic( mnemonic: string, options: Partial = {}, ): Promise { @@ -166,7 +166,7 @@ export class ModifyingSecp256k1HdWallet extends Secp256k1HdWallet { return new ModifyingSecp256k1HdWallet(mnemonicChecked, { ...options, seed: seed }); } - public async signAmino(signerAddress: string, signDoc: StdSignDoc): Promise { + public override async signAmino(signerAddress: string, signDoc: StdSignDoc): Promise { const modifiedSignDoc = { ...signDoc, fee: { @@ -183,7 +183,7 @@ export class ModifyingSecp256k1HdWallet extends Secp256k1HdWallet { * A class for testing clients using a direct signer which modifies the transaction it receives before signing */ export class ModifyingDirectSecp256k1HdWallet extends DirectSecp256k1HdWallet { - public static async fromMnemonic( + public static override async fromMnemonic( mnemonic: string, options: Partial = {}, ): Promise { @@ -192,7 +192,7 @@ export class ModifyingDirectSecp256k1HdWallet extends DirectSecp256k1HdWallet { return new ModifyingDirectSecp256k1HdWallet(mnemonicChecked, { ...options, seed: seed }); } - public async signDirect(address: string, signDoc: SignDoc): Promise { + public override async signDirect(address: string, signDoc: SignDoc): Promise { const txBody = TxBody.decode(signDoc.bodyBytes); const modifiedTxBody = TxBody.fromPartial({ ...txBody, diff --git a/tsconfig.json b/tsconfig.json index b74563e36a..0e357021cb 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -11,6 +11,7 @@ "noEmitOnError": true, "noFallthroughCasesInSwitch": true, "noImplicitReturns": true, + "noImplicitOverride": true, "noUnusedLocals": false, "noUnusedParameters": false, "pretty": true,