mjs/cosmjs
mjs/cosmjs
1
0
Fork 0
mirror of https://github.com/cosmos/cosmjs.git synced 2025-03-11 14:09:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

stargate: Actually use custom type urls in AminoTypes

Browse Source
This commit is contained in:
willclarktech 2020-12-22 16:59:29 +00:00
parent fbf5d412c4
commit bf5fb7fca4
No known key found for this signature in database
GPG Key ID: 551A86E2E398ADF7
2 changed files with 34 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
packages/stargate/src/aminotypes.spec.ts
View File

@ -8,6 +8,18 @@ describe("AminoTypes", () => {
expect(msgType).toEqual("cosmos-sdk/MsgDelegate");
});
it("works with custom type url", () => {
const msgType = new AminoTypes({ "/my.CustomType": "my-sdk/CustomType" }).toAmino("/my.CustomType");
expect(msgType).toEqual("my-sdk/CustomType");
});
it("works with overridden type url", () => {
const msgType = new AminoTypes({
"/cosmos.staking.v1beta1.MsgDelegate": "my-override/MsgDelegate",
}).toAmino("/cosmos.staking.v1beta1.MsgDelegate");
expect(msgType).toEqual("my-override/MsgDelegate");
});
it("throws for unknown type url", () => {
expect(() => new AminoTypes().toAmino("/xxx.Unknown")).toThrowError(
/Type URL does not exist in the Amino message type register./i,
@ -21,6 +33,20 @@ describe("AminoTypes", () => {
expect(msgUrl).toEqual("/cosmos.staking.v1beta1.MsgDelegate");
});
it("works with custom type url", () => {
const msgType = new AminoTypes({ "/my.CustomType": "my-sdk/CustomType" }).fromAmino(
"my-sdk/CustomType",
);
expect(msgType).toEqual("/my.CustomType");
});
it("works with overridden type url", () => {
const msgType = new AminoTypes({
"/my.OverrideType": "cosmos-sdk/MsgDelegate",
}).fromAmino("cosmos-sdk/MsgDelegate");
expect(msgType).toEqual("/my.OverrideType");
});
it("throws for unknown type url", () => {
expect(() => new AminoTypes().fromAmino("cosmos-sdk/MsgUnknown")).toThrowError(
/Type does not exist in the Amino message type register./i,

11
packages/stargate/src/aminotypes.ts
View File

@ -27,11 +27,16 @@ export class AminoTypes {
private readonly register: Record<string, string>;
public constructor(additions: Record<string, string> = {}) {
this.register = { ...defaultTypes, ...additions };
const additionalAminoTypes = Object.values(additions);
const filteredDefaultTypes = Object.entries(defaultTypes).reduce(
(acc, [key, value]) => (additionalAminoTypes.includes(value) ? acc : { ...acc, [key]: value }),
{},
);
this.register = { ...filteredDefaultTypes, ...additions };
}
public toAmino(typeUrl: string): string {
const type = defaultTypes[typeUrl];
const type = this.register[typeUrl];
if (!type) {
throw new Error(
"Type URL does not exist in the Amino message type register. " +
@ -43,7 +48,7 @@ export class AminoTypes {
}
public fromAmino(type: string): string {
const [typeUrl] = Object.entries(defaultTypes).find(([_typeUrl, value]) => value === type) ?? [];
const [typeUrl] = Object.entries(this.register).find(([_typeUrl, value]) => value === type) ?? [];
if (!typeUrl) {
throw new Error(
"Type does not exist in the Amino message type register. " +