Fix message format for feed items with no title or link (#737)

* Allow empty title on feed item

* Allow bare URL

* Add tests for new format.

* changelog

changelog.d/737.bugfix

@@ -0,0 +1 @@
+Fix feed message format when the item does not contain a title or link.

src/Connections/FeedConnection.ts

@@ -41,6 +41,7 @@ const MAX_TEMPLATE_LENGTH = 1024;
 
 const DEFAULT_TEMPLATE = "New post in $FEEDNAME";
 const DEFAULT_TEMPLATE_WITH_CONTENT = "New post in $FEEDNAME: $LINK"
+const DEFAULT_TEMPLATE_WITH_ONLY_TITLE = "New post in $FEEDNAME: $TITLE"
 
 @Connection
 export class FeedConnection extends BaseConnection implements IConnection {
@@ -145,6 +146,8 @@ export class FeedConnection extends BaseConnection implements IConnection {
                     return entry.title || "";
                 case "$LINK":
                     return entry.link ? `[${entry.title ?? entry.link}](${entry.link})` : "";
+                case "$URL":
+                    return entry.link || "";
                 case "$AUTHOR":
                     return entry.author || "";
                 case "$DATE":
@@ -183,8 +186,10 @@ export class FeedConnection extends BaseConnection implements IConnection {
         let message;
         if (this.state.template) {
             message = this.templateFeedEntry(this.state.template, entry);
-        } else if (entry.title && entry.link) {
+        } else if (entry.link) {
             message = this.templateFeedEntry(DEFAULT_TEMPLATE_WITH_CONTENT, entry);
+        } else if (entry.title) {
+            message = this.templateFeedEntry(DEFAULT_TEMPLATE_WITH_ONLY_TITLE, entry);
         } else {
             message = this.templateFeedEntry(DEFAULT_TEMPLATE, entry);
         }

tests/connections/FeedTest.spec.ts

@@ -54,6 +54,32 @@ describe("FeedConnection", () => {
         expect(matrixEvt.content.external_url).to.be.undefined;
         expect(matrixEvt.content.body).to.equal("New post in Test feed");
     });
+    it("will handle simple feed message with a missing title ", async () => {
+        const [connection, intent] = createFeed({
+            url: FEED_URL,
+        });
+        await connection.handleFeedEntry({
+            ...FEED_ENTRY_DEFAULTS,
+            title: null,
+        });
+        const matrixEvt =intent.sentEvents[0];
+        expect(matrixEvt).to.not.be.undefined;
+        expect(matrixEvt.roomId).to.equal(ROOM_ID);
+        expect(matrixEvt.content.body).to.equal("New post in Test feed: [foo/bar](foo/bar)");
+    });
+    it("will handle simple feed message with a missing link ", async () => {
+        const [connection, intent] = createFeed({
+            url: FEED_URL,
+        });
+        await connection.handleFeedEntry({
+            ...FEED_ENTRY_DEFAULTS,
+            link: null,
+        });
+        const matrixEvt =intent.sentEvents[0];
+        expect(matrixEvt).to.not.be.undefined;
+        expect(matrixEvt.roomId).to.equal(ROOM_ID);
+        expect(matrixEvt.content.body).to.equal("New post in Test feed: Foo");
+    });
     it("will handle simple feed message with all the template options possible ", async () => {
         const [connection, intent] = createFeed({
             url: FEED_URL,