nodejs/hookshot
nodejs/hookshot
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-hookshot.git synced 2025-03-10 21:19:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Argh permissions bug

Browse Source
This commit is contained in:
Half-Shot 2022-01-17 10:04:23 +00:00
parent 72eb24bf57
commit 7e2ffdd2df
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Config/permissions.rs
View File

@ -61,10 +61,7 @@ impl BridgePermissions {
if actor_permission.actor.starts_with("!") { if actor_permission.actor.starts_with("!") {
match self.room_membership.get(&actor_permission.actor) { match self.room_membership.get(&actor_permission.actor) {
Some(set) => { Some(set) => {
if !set.contains(mxid) { return set.contains(mxid);
// User not in set.
return false;
}
} }
None => { None => {
// No cached data stored...odd. // No cached data stored...odd.

2
tests/config/permissions.ts
View File

@ -56,7 +56,7 @@ describe("Config/BridgePermissions", () => {
it("will return true if a user is present in a room", () => { it("will return true if a user is present in a room", () => {
const bridgePermissions = genBridgePermissions('!foo:bar', 'my-service', 'login'); const bridgePermissions = genBridgePermissions('!foo:bar', 'my-service', 'login');
bridgePermissions.addMemberToCache('!foo:bar', '@foo:bar'); bridgePermissions.addMemberToCache('!foo:bar', '@foo:bar');
expect(bridgePermissions.checkAction("@foo:bar", "my-service", "login")).to.be.false; expect(bridgePermissions.checkAction("@foo:bar", "my-service", "login")).to.be.true;
}); });
it("will fall through and return true for multiple permission sets", () => { it("will fall through and return true for multiple permission sets", () => {
const bridgePermissions = new BridgePermissions([ const bridgePermissions = new BridgePermissions([