nodejs/hookshot
nodejs/hookshot
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-hookshot.git synced 2025-03-10 13:17:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not explicitly pass --target to rustup (#184)

Browse Source 
* Do not explicitly pass --target to rustup

It doesn't seem to be necessary to install Rust.
Passing `--target` prevents the Dockerfile from being built on different architectures.
Not passing it makes it auto-detect what to install.

Discussed here: https://github.com/spantaleev/matrix-docker-ansible-deploy/pull/1505

* Add changelog entry
This commit is contained in:
Slavi Pantaleev 2022-01-31 20:27:10 +02:00 committed by GitHub
parent b07aaedd04
commit 818bb03364
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Dockerfile
View File

@ -7,7 +7,7 @@ COPY . /src
WORKDIR /src
# We need rustup so we have a sensible rust version, the version packed with bullsye is too old
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y --profile minimal --target x86_64-unknown-linux-gnu
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y --profile minimal
ENV PATH="/root/.cargo/bin:${PATH}"
# Workaround: Need to install esbuild manually https://github.com/evanw/esbuild/issues/462#issuecomment-771328459

1
changelog.d/184.misc Normal file
View File

@ -0,0 +1 @@
Do not hardcode `--target x86_64-unknown-linux-gnu` when installing Rust (rely on platform auto-detection instead)