swift/Beam
swift/Beam
1
0
Fork 0
mirror of https://github.com/element-hq/element-x-ios.git synced 2025-03-10 21:39:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Delete more unnecessary logs

Browse Source
This commit is contained in:
Stefan Ceriu 2024-08-07 17:05:14 +03:00 committed by Stefan Ceriu
parent 91a42538ac
commit 0c47ea7231
6 changed files with 2 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ElementX/Sources/Screens/HomeScreen/HomeScreenViewModel.swift
View File

@ -343,8 +343,6 @@ class HomeScreenViewModel: HomeScreenViewModelType, HomeScreenViewModelProtocol
return
}
MXLog.verbose("Updating rooms")
var rooms = [HomeScreenRoom]()
for summary in roomSummaryProvider.roomListPublisher.value {
@ -353,8 +351,6 @@ class HomeScreenViewModel: HomeScreenViewModelType, HomeScreenViewModelProtocol
}
state.rooms = rooms
MXLog.verbose("Finished updating rooms")
}
private func updateVisibleRange(_ range: Range<Int>) {

4
ElementX/Sources/Screens/MessageForwardingScreen/MessageForwardingScreenViewModel.swift
View File

@ -81,8 +81,6 @@ class MessageForwardingScreenViewModel: MessageForwardingScreenViewModelType, Me
// MARK: - Private
private func updateRooms() {
MXLog.verbose("Updating rooms")
var rooms = [MessageForwardingRoom]()
for summary in roomSummaryProvider.roomListPublisher.value {
@ -95,8 +93,6 @@ class MessageForwardingScreenViewModel: MessageForwardingScreenViewModelType, Me
}
state.rooms = rooms
MXLog.verbose("Finished updating rooms")
}
/// The actual range values don't matter as long as they contain the lower

1
ElementX/Sources/Screens/RoomScreen/View/Timeline/TimelineTableViewController.swift
View File

@ -323,7 +323,6 @@ class TimelineTableViewController: UIViewController {
snapshot.appendItems(timelineItemsIDs)
let currentSnapshot = dataSource.snapshot()
MXLog.verbose("DIFF: \(snapshot.itemIdentifiers.difference(from: currentSnapshot.itemIdentifiers))")
// We only animate when new items come at the end of a live timeline, ignoring transitions through empty.
let newestItemIdentifier = snapshot.mainItemIdentifiers.first

2
ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProvider.swift
View File

@ -264,7 +264,6 @@ class RoomSummaryProvider: RoomSummaryProviderProtocol {
switch diff {
case .append(let values):
let debugIdentifiers = values.map { $0.id() }
for (index, value) in values.enumerated() {
let summary = buildRoomSummary(from: value)
changes.append(.insert(offset: rooms.count + index, element: summary, associatedWith: nil))
@ -295,7 +294,6 @@ class RoomSummaryProvider: RoomSummaryProviderProtocol {
let summary = rooms[Int(index)]
changes.append(.remove(offset: Int(index), element: summary, associatedWith: nil))
case .reset(let values):
let debugIdentifiers = values.map { $0.id() }
for (index, summary) in rooms.enumerated() {
changes.append(.remove(offset: index, element: summary, associatedWith: nil))
}

19
ElementX/Sources/Services/Timeline/RoomTimelineProvider.swift
View File

@ -94,8 +94,6 @@ class RoomTimelineProvider: RoomTimelineProviderProtocol {
span.exit()
}
MXLog.verbose("Received timeline diff")
itemProxies = diffs.reduce(itemProxies) { currentItems, diff in
guard let collectionDiff = buildDiff(from: diff, on: currentItems) else {
MXLog.error("Failed building CollectionDifference from \(diff)")
@ -110,8 +108,6 @@ class RoomTimelineProvider: RoomTimelineProviderProtocol {
return updatedItems
}
MXLog.verbose("Finished applying diffs, current items (\(itemProxies.count)) : \(itemProxies.map(\.debugIdentifier))")
if let hasLoadedInitialItemsContinuation {
hasLoadedInitialItemsContinuation.resume()
self.hasLoadedInitialItemsContinuation = nil
@ -126,7 +122,6 @@ class RoomTimelineProvider: RoomTimelineProviderProtocol {
case .append:
guard let items = diff.append() else { fatalError() }
MXLog.verbose("Append \(items.map(\.debugIdentifier))")
for (index, item) in items.enumerated() {
let itemProxy = TimelineItemProxy(item: item)
@ -137,32 +132,25 @@ class RoomTimelineProvider: RoomTimelineProviderProtocol {
changes.append(.insert(offset: Int(itemProxies.count) + index, element: itemProxy, associatedWith: nil))
}
case .clear:
MXLog.verbose("Clear all items")
for (index, itemProxy) in itemProxies.enumerated() {
changes.append(.remove(offset: index, element: itemProxy, associatedWith: nil))
}
case .insert:
guard let update = diff.insert() else { fatalError() }
MXLog.verbose("Insert \(update.item.debugIdentifier) at \(update.index)")
let itemProxy = TimelineItemProxy(item: update.item)
changes.append(.insert(offset: Int(update.index), element: itemProxy, associatedWith: nil))
case .popBack:
guard let itemProxy = itemProxies.last else { fatalError() }
MXLog.verbose("Pop Back \(itemProxy.debugIdentifier)")
changes.append(.remove(offset: itemProxies.count - 1, element: itemProxy, associatedWith: nil))
case .popFront:
guard let itemProxy = itemProxies.first else { fatalError() }
MXLog.verbose("Pop Front \(itemProxy.debugIdentifier)")
changes.append(.remove(offset: 0, element: itemProxy, associatedWith: nil))
case .pushBack:
guard let item = diff.pushBack() else { fatalError() }
MXLog.verbose("Push Back \(item.debugIdentifier)")
let itemProxy = TimelineItemProxy(item: item)
if itemProxy.isMembershipChange {
@ -173,7 +161,6 @@ class RoomTimelineProvider: RoomTimelineProviderProtocol {
case .pushFront:
guard let item = diff.pushFront() else { fatalError() }
MXLog.verbose("Push Front: \(item.debugIdentifier)")
let itemProxy = TimelineItemProxy(item: item)
changes.append(.insert(offset: 0, element: itemProxy, associatedWith: nil))
case .remove:
@ -181,13 +168,10 @@ class RoomTimelineProvider: RoomTimelineProviderProtocol {
let itemProxy = itemProxies[Int(index)]
MXLog.verbose("Remove \(itemProxy.debugIdentifier) at: \(index)")
changes.append(.remove(offset: Int(index), element: itemProxy, associatedWith: nil))
case .reset:
guard let items = diff.reset() else { fatalError() }
MXLog.verbose("Replace all items with \(items.map(\.debugIdentifier))")
for (index, itemProxy) in itemProxies.enumerated() {
changes.append(.remove(offset: index, element: itemProxy, associatedWith: nil))
}
@ -198,7 +182,6 @@ class RoomTimelineProvider: RoomTimelineProviderProtocol {
case .set:
guard let update = diff.set() else { fatalError() }
MXLog.verbose("Set \(update.item.debugIdentifier) at index \(update.index)")
let itemProxy = TimelineItemProxy(item: update.item)
changes.append(.remove(offset: Int(update.index), element: itemProxy, associatedWith: nil))
changes.append(.insert(offset: Int(update.index), element: itemProxy, associatedWith: nil))

2
ElementX/Sources/Services/Timeline/TimelineProxy.swift
View File

@ -408,7 +408,7 @@ final class TimelineProxy: TimelineProxyProtocol {
}
func sendReadReceipt(for eventID: String, type: ReceiptType) async -> Result<Void, TimelineProxyError> {
MXLog.verbose("Sending read receipt for eventID: \(eventID)")
MXLog.info("Sending read receipt for eventID: \(eventID)")
do {
try await timeline.sendReadReceipt(receiptType: type, eventId: eventID)