swift/Beam
swift/Beam
1
0
Fork 0
mirror of https://github.com/element-hq/element-x-ios.git synced 2025-03-10 21:39:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't pass a URL as a log destination to rust (#2506)

Browse Source 
On macOS (catalyst) URL.appGroupContainerDirectory returns:

/Users/matthew/Library/Group%20Containers/group.io.element/

So you need to strip the %20 out into a space, otherwise logging
fails with a permissions error.

* Use path(percentEncoded:)
This commit is contained in:
Matthew Hodgson 2024-02-28 12:28:17 +00:00 committed by GitHub
parent f5c43ed68f
commit 14d76d9860
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ElementX/Sources/Other/Logging/RustTracing.swift
View File

@ -45,14 +45,14 @@ enum RustTracing {
otlpEndpoint: otlpConfiguration.url,
filter: configuration.filter,
writeToStdoutOrSystem: true,
writeToFiles: .init(path: logsDirectory.path(),
writeToFiles: .init(path: logsDirectory.path(percentEncoded: false),
filePrefix: configuration.fileName,
fileSuffix: configuration.fileExtension,
maxFiles: maxFiles)))
} else {
setupTracing(config: .init(filter: configuration.filter,
writeToStdoutOrSystem: true,
writeToFiles: .init(path: logsDirectory.path(),
writeToFiles: .init(path: logsDirectory.path(percentEncoded: false),
filePrefix: configuration.fileName,
fileSuffix: configuration.fileExtension,
maxFiles: maxFiles)))

1
changelog.d/pr-2506.bugfix Normal file
View File

@ -0,0 +1 @@
Don't pass a URL as a log destination to rust on macOS