Fix interminable room directory search next page loading loops when results don't fill the screen

ElementX/Sources/Screens/RoomDirectorySearchScreen/RoomDirectorySearchScreenViewModel.swift

@@ -104,6 +104,10 @@ class RoomDirectorySearchScreenViewModel: RoomDirectorySearchScreenViewModelType
     }
     
     private func loadNextPage() {
+        guard !state.isLoading else {
+            return
+        }
+        
         Task {
             state.isLoading = true
             let _ = await roomDirectorySearchProxy.nextPage()

ElementX/Sources/Screens/RoomDirectorySearchScreen/View/RoomDirectorySearchScreen.swift

@@ -40,15 +40,13 @@ struct RoomDirectorySearchScreen: View {
                                 .foregroundColor(.compound.textSecondary)
                                 .frame(maxWidth: .infinity)
                                 .accessibilityIdentifier(A11yIdentifiers.startChatScreen.searchNoResults)
-                        } else {
+                        }
-                            // This needs to be in the else as when you start a search, the results are cleared making the footer visible.
+                        
-                            // We only want to trigger the pagination when the state is not loading.
                         emptyRectangle
                             .onAppear {
                                 context.send(viewAction: .reachedBottom)
                             }
                     }
-                    }
                     .listRowSeparator(.hidden)
                 }
             }