swift/Beam
swift/Beam
1
0
Fork 0
mirror of https://github.com/element-hq/element-x-ios.git synced 2025-03-10 21:39:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable identity pinning violation notifications unconditionally (#3457)

Browse Source 
(Remove the feature flag we added when this feature seemed unstable.)
This commit is contained in:
Andy Balaam 2024-10-28 12:16:38 +00:00 committed by GitHub
parent ed8aed65c7
commit 4e812f72b9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ElementX/Sources/Application/AppSettings.swift
View File

@ -46,7 +46,6 @@ final class AppSettings {
case publicSearchEnabled case publicSearchEnabled
case fuzzyRoomListSearchEnabled case fuzzyRoomListSearchEnabled
case enableOnlySignedDeviceIsolationMode case enableOnlySignedDeviceIsolationMode
case identityPinningViolationNotificationsEnabled
case knockingEnabled case knockingEnabled
case frequentEmojisEnabled case frequentEmojisEnabled
} }
@ -284,9 +283,6 @@ final class AppSettings {
@UserPreference(key: UserDefaultsKeys.optimizeMediaUploads, defaultValue: false, storageType: .userDefaults(store)) @UserPreference(key: UserDefaultsKeys.optimizeMediaUploads, defaultValue: false, storageType: .userDefaults(store))
var optimizeMediaUploads var optimizeMediaUploads
@UserPreference(key: UserDefaultsKeys.identityPinningViolationNotificationsEnabled, defaultValue: isDevelopmentBuild, storageType: .userDefaults(store))
var identityPinningViolationNotificationsEnabled
@UserPreference(key: UserDefaultsKeys.knockingEnabled, defaultValue: false, storageType: .userDefaults(store)) @UserPreference(key: UserDefaultsKeys.knockingEnabled, defaultValue: false, storageType: .userDefaults(store))
var knockingEnabled var knockingEnabled

4
ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift
View File

@ -142,9 +142,7 @@ class RoomScreenViewModel: RoomScreenViewModelType, RoomScreenViewModelProtocol
} }
.store(in: &cancellables) .store(in: &cancellables)
let identityStatusChangesPublisher = roomProxy.identityStatusChangesPublisher let identityStatusChangesPublisher = roomProxy.identityStatusChangesPublisher.receive(on: DispatchQueue.main)
.receive(on: DispatchQueue.main)
.filter { [weak self] _ in self?.appSettings.identityPinningViolationNotificationsEnabled ?? false }
Task { [weak self] in Task { [weak self] in
for await changes in identityStatusChangesPublisher.values { for await changes in identityStatusChangesPublisher.values {

1
ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/DeveloperOptionsScreenModels.swift
View File

@ -49,7 +49,6 @@ protocol DeveloperOptionsProtocol: AnyObject {
var optimizeMediaUploads: Bool { get set } var optimizeMediaUploads: Bool { get set }
var enableOnlySignedDeviceIsolationMode: Bool { get set } var enableOnlySignedDeviceIsolationMode: Bool { get set }
var elementCallBaseURLOverride: URL? { get set } var elementCallBaseURLOverride: URL? { get set }
var identityPinningViolationNotificationsEnabled: Bool { get set }
var knockingEnabled: Bool { get set } var knockingEnabled: Bool { get set }
var frequentEmojisEnabled: Bool { get set } var frequentEmojisEnabled: Bool { get set }
} }

4
ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/View/DeveloperOptionsScreen.swift
View File

@ -50,10 +50,6 @@ struct DeveloperOptionsScreen: View {
Text("Hide image & video previews") Text("Hide image & video previews")
} }
Toggle(isOn: $context.identityPinningViolationNotificationsEnabled) {
Text("Identity pinning violation notifications")
}
Toggle(isOn: $context.frequentEmojisEnabled) { Toggle(isOn: $context.frequentEmojisEnabled) {
Text("Show frequently used emojis") Text("Show frequently used emojis")
} }