mirror of
https://github.com/element-hq/element-x-ios.git
synced 2025-03-10 21:39:12 +00:00
Use the new strings for send failures when the unsigned devices are your own. (#3299)
This commit is contained in:
parent
16812e21ea
commit
63a0a99dbd
@ -23,18 +23,23 @@ enum ResolveVerifiedUserSendFailureScreenViewModelAction {
|
||||
struct ResolveVerifiedUserSendFailureScreenViewState: BindableState {
|
||||
var currentFailure: TimelineItemSendFailure.VerifiedUser
|
||||
var currentMemberDisplayName: String
|
||||
var isYou: Bool
|
||||
|
||||
var title: String {
|
||||
switch currentFailure {
|
||||
case .hasUnsignedDevice: L10n.screenResolveSendFailureUnsignedDeviceTitle(currentMemberDisplayName)
|
||||
case .changedIdentity: L10n.screenResolveSendFailureChangedIdentityTitle(currentMemberDisplayName)
|
||||
case .hasUnsignedDevice:
|
||||
isYou ? L10n.screenResolveSendFailureYouUnsignedDeviceTitle : L10n.screenResolveSendFailureUnsignedDeviceTitle(currentMemberDisplayName)
|
||||
case .changedIdentity:
|
||||
L10n.screenResolveSendFailureChangedIdentityTitle(currentMemberDisplayName)
|
||||
}
|
||||
}
|
||||
|
||||
var subtitle: String {
|
||||
switch currentFailure {
|
||||
case .hasUnsignedDevice: L10n.screenResolveSendFailureUnsignedDeviceSubtitle(currentMemberDisplayName, currentMemberDisplayName)
|
||||
case .changedIdentity: L10n.screenResolveSendFailureChangedIdentitySubtitle(currentMemberDisplayName)
|
||||
case .hasUnsignedDevice:
|
||||
isYou ? L10n.screenResolveSendFailureYouUnsignedDeviceSubtitle : L10n.screenResolveSendFailureUnsignedDeviceSubtitle(currentMemberDisplayName, currentMemberDisplayName)
|
||||
case .changedIdentity:
|
||||
L10n.screenResolveSendFailureChangedIdentitySubtitle(currentMemberDisplayName)
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -49,7 +49,8 @@ class ResolveVerifiedUserSendFailureScreenViewModel: ResolveVerifiedUserSendFail
|
||||
}
|
||||
|
||||
super.init(initialViewState: ResolveVerifiedUserSendFailureScreenViewState(currentFailure: failure,
|
||||
currentMemberDisplayName: members[userID]?.displayName ?? userID))
|
||||
currentMemberDisplayName: members[userID]?.displayName ?? userID,
|
||||
isYou: userID == roomProxy.ownUserID))
|
||||
}
|
||||
|
||||
// MARK: Public
|
||||
@ -83,6 +84,7 @@ class ResolveVerifiedUserSendFailureScreenViewModel: ResolveVerifiedUserSendFail
|
||||
if let (userID, failure) = iterator.next() {
|
||||
state.currentMemberDisplayName = members[userID]?.displayName ?? userID
|
||||
state.currentFailure = failure
|
||||
state.isYou = userID == roomProxy.ownUserID
|
||||
} else {
|
||||
actionsSubject.send(.dismiss)
|
||||
}
|
||||
|
@ -78,12 +78,16 @@ struct ResolveVerifiedUserSendFailureScreen: View {
|
||||
|
||||
struct ResolveVerifiedUserSendFailureScreen_Previews: PreviewProvider, TestablePreview {
|
||||
static let unsignedDeviceViewModel = makeViewModel(failure: .hasUnsignedDevice(devices: ["@alice:matrix.org": []]))
|
||||
static let ownUnsignedDeviceViewModel = makeViewModel(failure: .hasUnsignedDevice(devices: [RoomMemberProxyMock.mockMe.userID: []]))
|
||||
static let changedIdentityViewModel = makeViewModel(failure: .changedIdentity(users: ["@alice:matrix.org"]))
|
||||
|
||||
static var previews: some View {
|
||||
ResolveVerifiedUserSendFailureScreen(context: unsignedDeviceViewModel.context)
|
||||
.previewDisplayName("Unsigned Device")
|
||||
|
||||
ResolveVerifiedUserSendFailureScreen(context: ownUnsignedDeviceViewModel.context)
|
||||
.previewDisplayName("Own Unsigned Device")
|
||||
|
||||
ResolveVerifiedUserSendFailureScreen(context: changedIdentityViewModel.context)
|
||||
.previewDisplayName("Identity Changed")
|
||||
}
|
||||
|
@ -93,7 +93,9 @@ struct TimelineItemMenu: View {
|
||||
Divider()
|
||||
.padding(.horizontal, -16)
|
||||
|
||||
VerifiedUserSendFailureView(failure: failure, members: context.viewState.members) {
|
||||
VerifiedUserSendFailureView(failure: failure,
|
||||
members: context.viewState.members,
|
||||
ownUserID: context.viewState.ownUserID) {
|
||||
send(.itemSendInfoTapped(itemID: item.id))
|
||||
}
|
||||
.padding(.bottom, 8)
|
||||
@ -186,21 +188,26 @@ private struct VerifiedUserSendFailureView: View {
|
||||
let action: () -> Void
|
||||
|
||||
private let memberDisplayName: String
|
||||
private let isYou: Bool
|
||||
|
||||
init(failure: TimelineItemSendFailure.VerifiedUser,
|
||||
members: [String: RoomMemberState],
|
||||
ownUserID: String,
|
||||
action: @escaping () -> Void) {
|
||||
self.failure = failure
|
||||
self.action = action
|
||||
|
||||
let userIDs = failure.affectedUserIDs
|
||||
memberDisplayName = userIDs.first.map { members[$0]?.displayName ?? $0 } ?? ""
|
||||
isYou = ownUserID == userIDs.first
|
||||
}
|
||||
|
||||
var title: String {
|
||||
switch failure {
|
||||
case .hasUnsignedDevice: L10n.screenTimelineItemMenuSendFailureUnsignedDevice(memberDisplayName)
|
||||
case .changedIdentity: L10n.screenTimelineItemMenuSendFailureChangedIdentity(memberDisplayName)
|
||||
case .hasUnsignedDevice:
|
||||
isYou ? L10n.screenTimelineItemMenuSendFailureYouUnsignedDevice : L10n.screenTimelineItemMenuSendFailureUnsignedDevice(memberDisplayName)
|
||||
case .changedIdentity:
|
||||
L10n.screenTimelineItemMenuSendFailureChangedIdentity(memberDisplayName)
|
||||
}
|
||||
}
|
||||
|
||||
@ -241,6 +248,9 @@ struct TimelineItemMenu_Previews: PreviewProvider, TestablePreview {
|
||||
static let (unsignedDevicesItem, _) = makeItem(deliveryStatus: .sendingFailed(.verifiedUser(.hasUnsignedDevice(devices: [
|
||||
"@alice:matrix.org": ["DEVICE1", "DEVICE2"]
|
||||
]))))
|
||||
static let (ownUnsignedDevicesItem, _) = makeItem(deliveryStatus: .sendingFailed(.verifiedUser(.hasUnsignedDevice(devices: [
|
||||
RoomMemberProxyMock.mockMe.userID: ["DEVICE1"]
|
||||
]))))
|
||||
|
||||
static var previews: some View {
|
||||
TimelineItemMenu(item: item, actions: actions)
|
||||
@ -272,6 +282,10 @@ struct TimelineItemMenu_Previews: PreviewProvider, TestablePreview {
|
||||
.environmentObject(viewModel.context)
|
||||
.previewDisplayName("Unsigned Devices")
|
||||
|
||||
TimelineItemMenu(item: ownUnsignedDevicesItem, actions: actions)
|
||||
.environmentObject(viewModel.context)
|
||||
.previewDisplayName("Own Unsigned Devices")
|
||||
|
||||
TimelineItemMenu(item: identityChangedItem, actions: actions)
|
||||
.environmentObject(viewModel.context)
|
||||
.previewDisplayName("Identity Changed")
|
||||
|
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_resolveVerifiedUserSendFailureScreen-iPad-en-GB.Own-Unsigned-Device.png
(Stored with Git LFS)
Normal file
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_resolveVerifiedUserSendFailureScreen-iPad-en-GB.Own-Unsigned-Device.png
(Stored with Git LFS)
Normal file
Binary file not shown.
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_resolveVerifiedUserSendFailureScreen-iPad-pseudo.Own-Unsigned-Device.png
(Stored with Git LFS)
Normal file
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_resolveVerifiedUserSendFailureScreen-iPad-pseudo.Own-Unsigned-Device.png
(Stored with Git LFS)
Normal file
Binary file not shown.
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_resolveVerifiedUserSendFailureScreen-iPhone-15-en-GB.Own-Unsigned-Device.png
(Stored with Git LFS)
Normal file
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_resolveVerifiedUserSendFailureScreen-iPhone-15-en-GB.Own-Unsigned-Device.png
(Stored with Git LFS)
Normal file
Binary file not shown.
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_resolveVerifiedUserSendFailureScreen-iPhone-15-pseudo.Own-Unsigned-Device.png
(Stored with Git LFS)
Normal file
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_resolveVerifiedUserSendFailureScreen-iPhone-15-pseudo.Own-Unsigned-Device.png
(Stored with Git LFS)
Normal file
Binary file not shown.
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_timelineItemMenu-iPad-en-GB.Own-Unsigned-Devices.png
(Stored with Git LFS)
Normal file
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_timelineItemMenu-iPad-en-GB.Own-Unsigned-Devices.png
(Stored with Git LFS)
Normal file
Binary file not shown.
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_timelineItemMenu-iPad-pseudo.Own-Unsigned-Devices.png
(Stored with Git LFS)
Normal file
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_timelineItemMenu-iPad-pseudo.Own-Unsigned-Devices.png
(Stored with Git LFS)
Normal file
Binary file not shown.
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_timelineItemMenu-iPhone-15-en-GB.Own-Unsigned-Devices.png
(Stored with Git LFS)
Normal file
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_timelineItemMenu-iPhone-15-en-GB.Own-Unsigned-Devices.png
(Stored with Git LFS)
Normal file
Binary file not shown.
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_timelineItemMenu-iPhone-15-pseudo.Own-Unsigned-Devices.png
(Stored with Git LFS)
Normal file
BIN
PreviewTests/Sources/__Snapshots__/PreviewTests/test_timelineItemMenu-iPhone-15-pseudo.Own-Unsigned-Devices.png
(Stored with Git LFS)
Normal file
Binary file not shown.
Loading…
x
Reference in New Issue
Block a user