swift/Beam
swift/Beam
1
0
Fork 0
mirror of https://github.com/element-hq/element-x-ios.git synced 2025-03-10 21:39:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a bug where moving a new line in the composer could move the caret. (#3114)

Browse Source
This commit is contained in:
Doug 2024-08-05 14:46:40 +01:00 committed by GitHub
parent ff2c42d53b
commit 6a45ffc939
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ElementX/Sources/Screens/RoomScreen/ComposerToolbar/View/MessageComposerTextField.swift
View File

@ -105,6 +105,9 @@ private struct UITextViewWrapper: UIViewRepresentable {
.foregroundColor: UIColor(.compound.textPrimary)]
if textView.attributedText != text {
// Remember the selection if only the attributes have changed.
let selection = textView.attributedText.string == text.string ? textView.selectedTextRange : nil
textView.attributedText = text
// Re-apply the default font when setting text for e.g. edits.
@ -120,6 +123,11 @@ private struct UITextViewWrapper: UIViewRepresentable {
textView.keyboardType = .default
textView.reloadInputViews()
}
} else if let selection {
// Fixes a bug where pressing Return in the middle of two paragraphs
// moves the caret back to the bottom of the composer.
// https://github.com/element-hq/element-x-ios/issues/3104
textView.selectedTextRange = selection
}
}
}