swift/Beam
swift/Beam
1
0
Fork 0
mirror of https://github.com/element-hq/element-x-ios.git synced 2025-03-10 21:39:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update CONTRIBUTING.md (#2135)

Browse Source
This commit is contained in:
Doug 2023-11-22 08:54:17 +00:00 committed by GitHub
parent d03c97a02a
commit 7c3ee01a6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CONTRIBUTING.md
View File

@ -21,7 +21,7 @@ This will:
### Xcode ### Xcode
We suggest using an Xcode version later than 13.2.1. We suggest using an Xcode version later than 15.0.1.
The Xcode project can be directly compiled through the shared ElementX scheme which includes the main application as well as the unit and UI tests. The Xcode project can be directly compiled through the shared ElementX scheme which includes the main application as well as the unit and UI tests.
@ -55,12 +55,13 @@ Git LFS is used to store UI test snapshots. `swift run tools setup-project` will
``` ```
git lfs install git lfs install
ln -s "$(which git-lfs)" "$(git --exec-path)/git-lfs"
``` ```
### Snapshot Tests ### Snapshot Tests
If you make changes to the UI you may cause existing UI Snapshot tests to fail. You can run the snapshot tests using `UITests` target. To update the reference snapshots, delete them from `element-x-ios/UITests/Sources/__Snapshots__/Application` and run the tests again. If you make changes to the UI you may cause existing UI Snapshot tests to fail. You can run the snapshot tests using `UITests` target. To update the reference snapshots, delete them from `element-x-ios/UITests/Sources/__Snapshots__/Application` and run the tests again.
These are the devices we store snapshots for that you will need to run against: These are the devices we store snapshots for that you will need to run against which need to use the iOS 16.4 simulator in en-US for consistency:
- iPhone 14 - iPhone 14
- iPad (9th generation) - iPad (9th generation)