Finalise strings/icons for EncryptionAuthenticity. (#3121)

ElementX/Resources/Localizations/en.lproj/Localizable.strings

@@ -256,7 +256,7 @@
 "error_some_messages_have_not_been_sent" = "Some messages have not been sent";
 "error_unknown" = "Sorry, an error occurred";
 "event_shield_reason_authenticity_not_guaranteed" = "The authenticity of this encrypted message can't be guaranteed on this device.";
-"event_shield_reason_sent_in_clear" = "Sent in clear.";
+"event_shield_reason_sent_in_clear" = "Not encrypted.";
 "event_shield_reason_unknown_device" = "Encrypted by an unknown or deleted device.";
 "event_shield_reason_unsigned_device" = "Encrypted by a device not verified by its owner.";
 "event_shield_reason_unverified_identity" = "Encrypted by an unverified user.";

ElementX/Sources/Generated/Strings.swift

@@ -570,7 +570,7 @@ internal enum L10n {
   internal static var errorUnknown: String { return L10n.tr("Localizable", "error_unknown") }
   /// The authenticity of this encrypted message can't be guaranteed on this device.
   internal static var eventShieldReasonAuthenticityNotGuaranteed: String { return L10n.tr("Localizable", "event_shield_reason_authenticity_not_guaranteed") }
-  /// Sent in clear.
+  /// Not encrypted.
   internal static var eventShieldReasonSentInClear: String { return L10n.tr("Localizable", "event_shield_reason_sent_in_clear") }
   /// Encrypted by an unknown or deleted device.
   internal static var eventShieldReasonUnknownDevice: String { return L10n.tr("Localizable", "event_shield_reason_unknown_device") }

ElementX/Sources/Screens/RoomScreen/View/ItemMenu/TimelineItemMenu.swift

@@ -194,6 +194,7 @@ struct TimelineItemMenu_Previews: PreviewProvider, TestablePreview {
     static let viewModel = RoomScreenViewModel.mock
     static let (item, actions) = makeItem()
     static let (backupItem, _) = makeItem(authenticity: .notGuaranteed(color: .gray))
+    static let (unsignedItem, _) = makeItem(authenticity: .unsignedDevice(color: .red))
     static let (unencryptedItem, _) = makeItem(authenticity: .sentInClear(color: .red))
 
     static var previews: some View {
@@ -210,6 +211,10 @@ struct TimelineItemMenu_Previews: PreviewProvider, TestablePreview {
             .environmentObject(viewModel.context)
             .previewDisplayName("Authenticity not guaranteed")
         
+        TimelineItemMenu(item: unsignedItem, actions: actions)
+            .environmentObject(viewModel.context)
+            .previewDisplayName("Unsigned")
+        
         TimelineItemMenu(item: unencryptedItem, actions: actions)
             .environmentObject(viewModel.context)
             .previewDisplayName("Unencrypted")

ElementX/Sources/Services/Timeline/TimelineItemContent/EncryptionAuthenticity.swift

@@ -57,10 +57,10 @@ enum EncryptionAuthenticity: Hashable {
     }
     
     var icon: KeyPath<CompoundIcons, Image> {
-        // TODO: Should sentInClear have a dedicated icon???
-        switch color {
-        case .red: \.error
-        case .gray: \.info
+        switch self {
+        case .notGuaranteed: \.info
+        case .unknownDevice, .unsignedDevice, .unverifiedIdentity: \.helpSolid
+        case .sentInClear: \.lockOff
         }
     }
 }