UI test fixes (#235)

* Fix UI test simulator versions
* Pin the used Xcode version used by fastlane to `~> 14.0.1`, as simctl status_bar overrides don't work on the Xcode14.1 RC
* Update base screenshots, fix status bar script warning, fix settings screen test

.gitignore

@@ -44,9 +44,9 @@ Tools/Scripts/element-android
 # ignore all
 /UITests/Sources/__Snapshots__/Application/*
 # but keep the references
-!/UITests/Sources/__Snapshots__/Application/15-5-de-DE-iPad-9th-generation.*.png
+!/UITests/Sources/__Snapshots__/Application/16-0-de-DE-iPad-9th-generation.*.png
-!/UITests/Sources/__Snapshots__/Application/15-5-fr-FR-iPad-9th-generation.*.png
+!/UITests/Sources/__Snapshots__/Application/16-0-fr-FR-iPad-9th-generation.*.png
-!/UITests/Sources/__Snapshots__/Application/15-5-en-GB-iPad-9th-generation.*.png
+!/UITests/Sources/__Snapshots__/Application/16-0-en-GB-iPad-9th-generation.*.png
-!/UITests/Sources/__Snapshots__/Application/15-5-de-DE-iPhone-13-Pro-Max.*.png
+!/UITests/Sources/__Snapshots__/Application/16-0-de-DE-iPhone-13-Pro-Max.*.png
-!/UITests/Sources/__Snapshots__/Application/15-5-fr-FR-iPhone-13-Pro-Max.*.png
+!/UITests/Sources/__Snapshots__/Application/16-0-fr-FR-iPhone-13-Pro-Max.*.png
-!/UITests/Sources/__Snapshots__/Application/15-5-en-GB-iPhone-13-Pro-Max.*.png
+!/UITests/Sources/__Snapshots__/Application/16-0-en-GB-iPhone-13-Pro-Max.*.png

ElementX.xcodeproj/project.pbxproj

@@ -2242,6 +2242,7 @@
 /* Begin PBXShellScriptBuildPhase section */
 		17364E8B37FC780E07DDEAF7 /* Override Simulator Status Bars */ = {
 			isa = PBXShellScriptBuildPhase;
+			alwaysOutOfDate = 1;
 			buildActionMask = 2147483647;
 			files = (
 			);
@@ -2256,7 +2257,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "python3 $PROJECT_DIR/Tools/Scripts/bootTestSimulator.py --name 'iPhone 13 Pro Max' --version 'iOS.15.5'\npython3 $PROJECT_DIR/Tools/Scripts/bootTestSimulator.py --name 'iPad (9th generation)' --version 'iOS.15.5'\n";
+			shellScript = "python3 $PROJECT_DIR/Tools/Scripts/bootTestSimulator.py --name 'iPhone 13 Pro Max' --version 'iOS.16.0'\npython3 $PROJECT_DIR/Tools/Scripts/bootTestSimulator.py --name 'iPad (9th generation)' --version 'iOS.16.0'\n";
 		};
 		98CA896D84BFD53B2554E891 /* ⚠️ SwiftLint */ = {
 			isa = PBXShellScriptBuildPhase;

Tools/Scripts/bootTestSimulator.py

@@ -16,7 +16,7 @@ def runtime_name(runtime):
 
 parser = argparse.ArgumentParser()
 parser.add_argument('--name', type=str, help='Simulator name (like \'iPhone 13 Pro Max\')', required=True)
-parser.add_argument('--version', type=str, default='iOS.15.5', help='OS version (defaults to \'iOS.15.5\')', required=False)
+parser.add_argument('--version', type=str, default='iOS.16.0', help='OS version (defaults to \'iOS.16.0\')', required=False)
 
 args = vars(parser.parse_args())
 

UITests/Sources/SettingsUITests.swift

@@ -27,11 +27,12 @@ class SettingsUITests: XCTestCase {
         XCTAssert(reportBugButton.exists)
         XCTAssertEqual(reportBugButton.label, ElementL10n.sendBugReport)
         XCTAssertEqual(app.buttons["crashButton"].exists, BuildSettings.settingsCrashButtonVisible)
-        let timelineStylePicker = app.buttons["timelineStylePicker"]
+
-        XCTAssertEqual(timelineStylePicker.exists, BuildSettings.settingsShowTimelineStyle)
+        XCTAssertEqual(app.buttons["timelineStylePicker"].exists, BuildSettings.settingsShowTimelineStyle)
         if BuildSettings.settingsShowTimelineStyle {
-            XCTAssertEqual(timelineStylePicker.staticTexts.firstMatch.label, ElementL10n.settingsTimelineStyle)
+            XCTAssertTrue(app.staticTexts[ElementL10n.settingsTimelineStyle].exists)
         }
+        
         let logoutButton = app.buttons["logoutButton"]
         XCTAssert(logoutButton.exists)
         XCTAssertEqual(logoutButton.label, ElementL10n.logout)