* Add expand/collapse UI for reactions
- Adds a CollapsibleFlowLayout for controlling the layout
- Adds tests for this layout and some mocks for testing layouts generally
- Improves the rendering of the reaction buttons which were not pixel perfect
- Adds the UI for the expand collapse buttons including the count of hidden items in the collapsed state.
* Add comment for reactionsCollapsed binding.
* Add the add more button and change the layout to be reactions specific and account for the add more button specifics.
* Update CollapsibleReactionLayout.swift
* Rename lines to rows, to hopefully ease the incoming merge.
* Add LayoutValueKey to organise subviews by item type.
- create ReactionLayoutItemType to tag subviews with ReactionLayoutItem
- Add LayoutValueKey support to the layout mocks
- Fix some mistakes in the merge
- Make the test code a bit more DRY
- Make the animation of the addMore and collapse buttons consistent
* Fix naming of the add more button label
* Address comments and fix padding
- Fix typos
- Use pdf/svg for icon
- Fix incorrect padding from a bad merge
* Fix "Add more" button padding to match designs
* Update snapshot test reference images.
* Fix naming, add Preserves Vector Data
* Sort timetamps on timeline and show the date on the summary view
- Sort reaction aggregations on the timeline by count and then by most recent timestamp ascending(tagging new reactions on the end)
- Show the timestamp on the summary view and sort descending(newest at the top)
* Address comments.
- Fix ID case.
- Improve readability of components in body.
- Improve the comments that describe the sorting.
- Add `weak` to mock variables called `delegate`
- Delete `UserNotificationCenterSpy` and use `UserNotificationCenterMock`
- Remove Task.sleep in favour of mock closures along with expectations/fulfillment.
* add new asset for location, add logic for sharing user current location
* work on default zoom and auth for location
* add attribution button
* fix attribution button position, fix isSharingUserLocation
* Add NSLocationWhenInUseUsageDescription back
* Fix initial animation
* change map logo and attribution position
* Add annotation just in the setup
* add errors and alert for map vies
* location unit test
* add unit test for location sharing
* add changelog
* Update ElementX/Sources/Other/MapLibre/MapLibreMapView.swift
Co-authored-by: Alfonso Grillo <alfogrillo@gmail.com>
* add comments and minor parameters refactor
* Update ElementX/Sources/Screens/LocationSharing/StaticLocationScreenCoordinator.swift
Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
* Update ElementX/Sources/Screens/LocationSharing/StaticLocationScreenViewModel.swift
Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
* Sort assets
* Cleanup
* Cleanup
* Fix error localizations
* Fix tests
---------
Co-authored-by: Alfonso Grillo <alfogrillo@gmail.com>
Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com>
* Add signposts to performance tests.
- Update flow to include support for the migration screen.
* If the welcome screen shows, click on the button.
* Ensure a clean simulator each run.
* Add accessibility identifier for migration screen if required.
* Handle walking into the room and back out again.
* use iphone 14 pro to match what's used in xcode.
* Remove ApplicationTests as duplicated in LoginTests.
We measure app startup time in LoginTests as part of the flow - we may as well avoid spending 60s doing only that measurement in ApplicationTests
* Sleep 10s, the ui is otherwise showing up in random order.
* Revert "Remove ApplicationTests as duplicated in LoginTests."
This reverts commit 8670710315bcd0d6c3c3046f534b32b4c728b837.
* Update script to parse out correct values from results file.
* Allow cancellation of password prompt in any order.
* Remove test timeout, performance tests will always take a while.
* Adjust parsing further
* Remove ApplicationTests.
* Move to a more elegant way to wait for something to disappear.
* Linting.
* Fix unit tests.
---------
Co-authored-by: Doug <douglase@element.io>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
* Add expand/collapse UI for reactions
- Adds a CollapsibleFlowLayout for controlling the layout
- Adds tests for this layout and some mocks for testing layouts generally
- Improves the rendering of the reaction buttons which were not pixel perfect
- Adds the UI for the expand collapse buttons including the count of hidden items in the collapsed state.
* Add comment for reactionsCollapsed binding.
* Remove Flow and simplify implementation
- Remove SwiftUI-Flow
- Add strings by importing from Localyse
- Remove count on expand button as requires GeometryReader and can cause loops
- Don't use GeometryReader for hiding reactions with opacity(just put them way off screen for now)
- Fix unit and UI tests
* Address PR comments
- use synthesized inits
- use rows rather than lines for naming flow layout
- other naming improvements
- reactions were already rendered in another ui test, removing my test on favour of those and updating the screenshots for those.
* Add xcAwaitDeferred to aid with tests that have publishers.
* Improve naming
* Address Comments
- Fix naming
- Add optional expectation message
- Use trailing closure syntax
* the screen renders and changed the analytics checkmark to be more generic
* welcome screen
* transition
* tests... TODO
* changelog
* changed assets and added multilineTextAlignment
* better naming
* fix for missing after migration but has a weird presentaiton bug
* fix
* icon color
* Add reaction summary view
* Add avatars and display names and flowlayout for reactions
- Add avatars to summary view
- Add display names to summary view
- Add flow layout to reaction buttons as per designs(long press on scolling buttons is difficult to achieve so prioritised this).
* Add and use SwiftUI-Flow for reaction layout.
* Correct Swift-Flow inclusion via xcodegen
* Remove own FlowLayout implementation and Fix unit tests
* Improve naming and correct spacing on summary view as per design.
* Fix safe area insets on summary view bottom sheet
* Scroll to selected reaction in the case that it is offscreen when the sheet is displayed.
* Add more reactions to UITests to ensure the new flow layout is displayed(wraps on to second line).
* Fix snapshot image.
* Address review comments.
* Use onLongPressGesture for reactions also to fix double actions bug and for consistency.
* Respect RTL languages.
* Fix unit test.
* Replace FilePreviewScreen with InteractiveQuickLook.
- Allows full screen presentation.
- Allows dismiss gesture to work.
- Presentation looks much better on macOS.
Squashed commits:
[d64bb3bb] Stop using the ServiceLocator directly in the ScreenTrackerViewModifier
[37c46ab9] Rename Analytics to AnalyticsService
[8852a371] #920 - Cleanup ServiceLocator usages
* Fixes#1121 - Hide the loading indicator after the logout task finishes
* Manually restart the sync only when entering the `error` state
* Use stopSync instead of the roomListService directly on client deinit
* Replace WeakClientProxyWrapper with callback based delegate
* Fix homescreen user avatar not automatically updating
* Replace default Build SDK profile with reldbg, which is fast but also doesn't crash
* Always show the loading indicator when the room list is not in a `running` state
* Implement delayed user indicator presentations through the normal API
* Fix the unit tests
* Replace UserIndicatorController delayedIndicators dictionary with a plain set
* Add support for message forwarding
* Move the TimelineProvider within the RoomProxy to avoid it going out of sync and have it automatically register for timeline updates on init
* Implement single selection form button style for message forwarding
* Add searching and filter out the source room from the list
* Fixed emoji screen initial search bar height
* Add view models tests
* Add changelog
* Update strings
* Tweaks following code review
* Tweak invites button frame and padding
* Implement persistent selections on the room list
* Stop showing rooms when focusing the room list search field with an empty query
* Tweaks after code review
* Improve invite button UI
* Fix unit tests
* Add support for the new RoomList API
Squashed commits:
[8c2625a] Re-enable invites
[339e59b5] Add automatic syncing restarts after entering the terminated state for whatever reason
[b5498e96] Reimplemented room list state management and usage
[8154b0cf] Fix visible rooms range setting after scrolling stops
[5155c44d] Hook up initial loading idicator and session verification banner to room list service states
[700a5a2e] Enable back room subscriptions, timeline listeners and unread notifications / counts
[9df383bc] Enable last messages and timestamps, they don't crash on release builds
[7c4da9da] Add back certain fields now that the "full room" is available
[9f6534a7] Adopt interfaces to new RoomList API, untested as requests don't go to the right URL
* Tweaks following code review
* Bump the RustSDK to v1.0.76-alpha
* is now possible to open the confirmation dialog and pass the transaction id
* task completed added some tests
* changelog
* title visibility set to .visible
* refactored alert info to not use the soon to be deprecated API
* missing files and changelog
* updated some tests
* Update ElementX/Sources/Screens/RoomMemberDetailsScreen/View/RoomMemberDetailsScreen.swift
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
---------
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
* testing improvements
* code improvements and sdk bump
* improved the stencil file
* improved the build sdk function
* code improvement
* also added the tearDown
* Inject user id into room’s details
* Refactor member fetch logic in RoomDetailsScreenViewModel
* Refactor DI
* Fetch members in RoomMembersListScreenViewModel
* Fetch members in InviteUsersScreen
* Use joinedMembersCount in room members list
* Cleanup
* Limit members refresh
* Cleanup binding
* Fix UT build errors
* Fix RoomDetailsScreenViewModelTests
* Fix RoomMembersListScreenViewModelTests
* Fix UTs
* Fix RoomDetailsScreenUITests
* Refine RoomDetailsScreenViewModelTests
* Add roomProxy extension
* PR comments
* Refactor room’s counter to Int
* Improve updateMembers() performances
* Fix memory leaks
* fix
* fixed RTL and LTR timestamp for all the cases! also improved the testing
* changelog
* better and less convoluted solution
* Update ElementX/Sources/Screens/RoomScreen/View/Timeline/FormattedBodyText.swift
Co-authored-by: Alfonso Grillo <alfogrillo@gmail.com>
* pr suggestion and removed prefix in reality it creates more issues than improvements, and is not really needed
---------
Co-authored-by: Alfonso Grillo <alfogrillo@gmail.com>
* Fixes#1011 - Add legal information screen in settings, move all settings related screens under Source/Screen/Settings
* Fix warnings after sliding sync api change
