mirror of
https://github.com/element-hq/element-x-ios.git
synced 2025-03-11 13:59:13 +00:00

* Add expand/collapse UI for reactions - Adds a CollapsibleFlowLayout for controlling the layout - Adds tests for this layout and some mocks for testing layouts generally - Improves the rendering of the reaction buttons which were not pixel perfect - Adds the UI for the expand collapse buttons including the count of hidden items in the collapsed state. * Add comment for reactionsCollapsed binding. * Remove Flow and simplify implementation - Remove SwiftUI-Flow - Add strings by importing from Localyse - Remove count on expand button as requires GeometryReader and can cause loops - Don't use GeometryReader for hiding reactions with opacity(just put them way off screen for now) - Fix unit and UI tests * Address PR comments - use synthesized inits - use rows rather than lines for naming flow layout - other naming improvements - reactions were already rendered in another ui test, removing my test on favour of those and updating the screenshots for those.
177 lines
6.6 KiB
Swift
177 lines
6.6 KiB
Swift
//
|
|
// Copyright 2022 New Vector Ltd
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//
|
|
|
|
import ElementX
|
|
import XCTest
|
|
|
|
@MainActor
|
|
class RoomScreenUITests: XCTestCase {
|
|
func testPlainNoAvatar() async throws {
|
|
let app = Application.launch(.roomPlainNoAvatar)
|
|
|
|
XCTAssert(app.staticTexts[A11yIdentifiers.roomScreen.name].exists)
|
|
XCTAssert(app.staticTexts[A11yIdentifiers.roomScreen.avatar].exists)
|
|
|
|
try await app.assertScreenshot(.roomPlainNoAvatar)
|
|
}
|
|
|
|
func testEncryptedWithAvatar() async throws {
|
|
let app = Application.launch(.roomEncryptedWithAvatar)
|
|
|
|
XCTAssert(app.staticTexts[A11yIdentifiers.roomScreen.name].exists)
|
|
XCTAssert(app.images[A11yIdentifiers.roomScreen.avatar].waitForExistence(timeout: 1))
|
|
|
|
try await app.assertScreenshot(.roomEncryptedWithAvatar)
|
|
}
|
|
|
|
func testSmallTimelineLayout() async throws {
|
|
let app = Application.launch(.roomSmallTimeline)
|
|
|
|
// The messages should be bottom aligned.
|
|
try await app.assertScreenshot(.roomSmallTimeline)
|
|
}
|
|
|
|
func testSmallTimelineWithIncomingAndPagination() async throws {
|
|
let client = try UITestsSignalling.Client(mode: .tests)
|
|
|
|
let app = Application.launch(.roomSmallTimelineIncomingAndSmallPagination)
|
|
|
|
await client.waitForApp()
|
|
defer { try? client.stop() }
|
|
|
|
// When a back pagination occurs and an incoming message arrives.
|
|
try await performOperation(.incomingMessage, using: client)
|
|
try await performOperation(.paginate, using: client)
|
|
|
|
// Then the 4 visible messages should stay aligned to the bottom.
|
|
try await app.assertScreenshot(.roomSmallTimelineIncomingAndSmallPagination)
|
|
}
|
|
|
|
func testSmallTimelineWithLargePagination() async throws {
|
|
let client = try UITestsSignalling.Client(mode: .tests)
|
|
|
|
let app = Application.launch(.roomSmallTimelineLargePagination)
|
|
|
|
await client.waitForApp()
|
|
defer { try? client.stop() }
|
|
|
|
// When a large back pagination occurs.
|
|
try await performOperation(.paginate, using: client)
|
|
|
|
// The bottom of the timeline should remain visible with more items added above.
|
|
try await app.assertScreenshot(.roomSmallTimelineLargePagination)
|
|
}
|
|
|
|
// This test is DISABLED because it's flakey on the CI
|
|
func disabled_testTimelineLayoutInMiddle() async throws {
|
|
let client = try UITestsSignalling.Client(mode: .tests)
|
|
|
|
let app = Application.launch(.roomLayoutMiddle)
|
|
|
|
await client.waitForApp()
|
|
defer { try? client.stop() }
|
|
|
|
try await Task.sleep(for: .seconds(1)) // Allow the table to settle
|
|
// Given a timeline that is neither at the top nor the bottom.
|
|
app.swipeDown()
|
|
try await Task.sleep(for: .seconds(1)) // Allow the table to settle
|
|
try await app.assertScreenshot(.roomLayoutMiddle, step: 0) // Assert initial state for comparison.
|
|
|
|
// When a back pagination occurs.
|
|
try await performOperation(.paginate, using: client)
|
|
|
|
// Then the UI should remain unchanged.
|
|
try await app.assertScreenshot(.roomLayoutMiddle, step: 0)
|
|
|
|
// When an incoming message arrives
|
|
try await performOperation(.incomingMessage, using: client)
|
|
|
|
// Then the UI should still remain unchanged.
|
|
try await app.assertScreenshot(.roomLayoutMiddle, step: 0)
|
|
|
|
// When the keyboard appears for the message composer.
|
|
try await tapMessageComposer(in: app)
|
|
|
|
// Then the timeline scroll offset should remain unchanged.
|
|
try await app.assertScreenshot(.roomLayoutMiddle, step: 1)
|
|
}
|
|
|
|
func testTimelineLayoutAtTop() async throws {
|
|
let client = try UITestsSignalling.Client(mode: .tests)
|
|
|
|
let app = Application.launch(.roomLayoutTop)
|
|
|
|
await client.waitForApp()
|
|
defer { try? client.stop() }
|
|
|
|
// Given a timeline that is scrolled to the top.
|
|
for _ in 0...5 {
|
|
app.swipeDown()
|
|
}
|
|
try await app.assertScreenshot(.roomLayoutTop) // Assert initial state for comparison.
|
|
|
|
// When a back pagination occurs.
|
|
try await performOperation(.paginate, using: client)
|
|
|
|
// Then the bottom of the timeline should remain unchanged (with new items having been added above).
|
|
try await app.assertScreenshot(.roomLayoutTop)
|
|
}
|
|
|
|
func testTimelineLayoutAtBottom() async throws {
|
|
let client = try UITestsSignalling.Client(mode: .tests)
|
|
|
|
let app = Application.launch(.roomLayoutBottom)
|
|
|
|
await client.waitForApp()
|
|
defer { try? client.stop() }
|
|
|
|
// Some time for the timeline to settle
|
|
try await Task.sleep(for: .seconds(1))
|
|
// When an incoming message arrives.
|
|
try await performOperation(.incomingMessage, using: client)
|
|
// Some time for the timeline to settle
|
|
try await Task.sleep(for: .seconds(1))
|
|
|
|
// Then the timeline should scroll down to reveal the message.
|
|
try await app.assertScreenshot(.roomLayoutBottom, step: 0)
|
|
|
|
// When the keyboard appears for the message composer.
|
|
try await tapMessageComposer(in: app)
|
|
|
|
try await app.assertScreenshot(.roomLayoutBottom, step: 1)
|
|
}
|
|
|
|
func testTimelineReadReceipts() async throws {
|
|
let app = Application.launch(.roomSmallTimelineWithReadReceipts)
|
|
|
|
// The messages should be bottom aligned.
|
|
try await app.assertScreenshot(.roomSmallTimelineWithReadReceipts)
|
|
}
|
|
|
|
// MARK: - Helper Methods
|
|
|
|
private func performOperation(_ operation: UITestsSignal, using client: UITestsSignalling.Client) async throws {
|
|
try client.send(operation)
|
|
await _ = client.signals.values.first { $0 == .success }
|
|
try await Task.sleep(for: .seconds(2)) // Allow the timeline to update
|
|
}
|
|
|
|
private func tapMessageComposer(in app: XCUIApplication) async throws {
|
|
app.textViews.element.tap()
|
|
try await Task.sleep(for: .seconds(10)) // Allow the animations to complete
|
|
}
|
|
}
|