mirror of
https://github.com/element-hq/element-x-ios.git
synced 2025-03-10 21:39:12 +00:00
e5da7ebd2d
* remove the ticket number check, it's noisy * remove signoff now that we have cla checks * fix description image attachments check
51 lines
1.8 KiB
Swift
51 lines
1.8 KiB
Swift
import Danger
|
|
import Foundation
|
|
|
|
SwiftLint.lint(.modifiedAndCreatedFiles(directory: nil),
|
|
inline: true,
|
|
configFile: nil,
|
|
strict: false,
|
|
quiet: true,
|
|
swiftlintPath: nil,
|
|
markdownAction: { _ in })
|
|
|
|
let danger = Danger()
|
|
|
|
// All of the new and modified files together.
|
|
let editedFiles = danger.git.modifiedFiles + danger.git.createdFiles
|
|
|
|
// Warn when there is a big PR
|
|
if (danger.github.pullRequest.additions ?? 0) > 1000 {
|
|
warn("This pull request seems relatively large. Please consider splitting it into multiple smaller ones.")
|
|
}
|
|
|
|
// Check that the PR has a description
|
|
if danger.github.pullRequest.body?.isEmpty ?? true {
|
|
warn("Please provide a description for this PR.")
|
|
}
|
|
|
|
// Check for screenshots on view changes
|
|
let hasChangedViews = !editedFiles.filter { $0.lowercased().contains("/view") }.isEmpty
|
|
if hasChangedViews {
|
|
if (danger.github.pullRequest.body?.contains("user-attachments") ?? false) == false {
|
|
warn("You seem to have made changes to views. Please consider adding screenshots.")
|
|
}
|
|
}
|
|
|
|
// Check for pngs on resources
|
|
let hasPngs = !editedFiles.filter { $0.lowercased().contains(".xcassets") && $0.lowercased().hasSuffix(".png") }.isEmpty
|
|
if hasPngs {
|
|
warn("You seem to have made changes to some resource images. Please consider using an SVG or PDF.")
|
|
}
|
|
|
|
// Check for nice PR titles
|
|
let fixesRegex = try! Regex("(Fixes|Fix) #\\d+")
|
|
if danger.github.pullRequest.title.hasSuffix("…") || danger.github.pullRequest.title.starts(with: fixesRegex) {
|
|
fail("Please provide a complete title that can be used as a changelog entry.")
|
|
}
|
|
|
|
// Check for changelog tags
|
|
if danger.github.issue.labels.filter({ $0.name.hasPrefix("pr-") }).count != 1 {
|
|
fail("Please add a `pr-` label to categorise the changelog entry.")
|
|
}
|