swift/Beam
swift/Beam
1
0
Fork 0
mirror of https://github.com/element-hq/element-x-ios.git synced 2025-03-10 13:37:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix integration tests. (#1793)

Browse Source 
There was a bug where another button existed with the same label.
This commit is contained in:
Doug 2023-09-25 13:45:50 +01:00 committed by GitHub
parent 2a6cf390d6
commit a2812525e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
IntegrationTests/Sources/UserFlowTests.swift
View File

@ -52,7 +52,7 @@ class UserFlowTests: XCTestCase {
invitesButton.tap()
// Go back to the room list
tapOnButton("All Chats")
tapOnBackButton("All Chats")
}
private func checkAttachmentsPicker() {
@ -84,9 +84,9 @@ class UserFlowTests: XCTestCase {
tapOnButton(A11yIdentifiers.inviteUsersScreen.proceed)
tapOnButton("Invite people")
tapOnBackButton("Invite people")
tapOnButton("Start chat")
tapOnBackButton("Start chat")
tapOnButton("Cancel")
@ -120,16 +120,16 @@ class UserFlowTests: XCTestCase {
firstRoomMember.tap()
// Go back to the room member details
tapOnButton("People")
tapOnBackButton("People")
// Go back to the room details
tapOnButton("Back")
tapOnBackButton()
// Go back to the room
tapOnButton("Back")
tapOnBackButton()
// Go back to the room list
tapOnButton("All Chats")
tapOnBackButton("All Chats")
}
private func checkSettings() {
@ -145,19 +145,19 @@ class UserFlowTests: XCTestCase {
tapOnButton(A11yIdentifiers.settingsScreen.analytics)
// Go back to settings
tapOnButton("Settings")
tapOnBackButton("Settings")
// Open report a bug
tapOnButton(A11yIdentifiers.settingsScreen.reportBug)
// Go back to settings
tapOnButton("Settings")
tapOnBackButton("Settings")
// Open about
tapOnButton(A11yIdentifiers.settingsScreen.about)
// Go back to settings
tapOnButton("Settings")
tapOnBackButton("Settings")
// Close the settings
tapOnButton(A11yIdentifiers.settingsScreen.done)
@ -168,4 +168,14 @@ class UserFlowTests: XCTestCase {
XCTAssertTrue(button.waitForExistence(timeout: 10.0))
button.tap()
}
/// Taps on a back button that the system configured with a label but no identifier.
///
/// When there are multiple buttons with the same label in the hierarchy, all the buttons we created
/// should have an identifier set, and so this method will ignore those picking the one with only a label.
private func tapOnBackButton(_ label: String = "Back") {
let button = app.buttons.matching(NSPredicate(format: "label == %@ && identifier == ''", label)).firstMatch
XCTAssertTrue(button.waitForExistence(timeout: 10.0))
button.tap()
}
}