swift/Beam
swift/Beam
1
0
Fork 0
mirror of https://github.com/element-hq/element-x-ios.git synced 2025-03-10 13:37:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tweak swiftlint settings

Browse Source
This commit is contained in:
Stefan Ceriu 2023-08-08 09:50:43 +03:00 committed by Stefan Ceriu
parent 10259e9345
commit dd6d1f6e63
20 changed files with 9 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.swiftlint.yml
View File

@ -24,7 +24,7 @@ line_length:
error: 1000
file_length:
warning: 800
warning: 1000
error: 1000
type_name:
@ -38,9 +38,12 @@ type_body_length:
error: 1000
function_body_length:
warning: 50
warning: 100
error: 100
cyclomatic_complexity:
ignores_case_statements: true
nesting:
type_level:
warning: 5

1
ElementX/Sources/Application/AppCoordinator.swift
View File

@ -241,7 +241,6 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationCoordinatorDelegate,
userSessionStore.reset()
}
// swiftlint:disable:next cyclomatic_complexity
private func setupStateMachine() {
stateMachine.addTransitionHandler { [weak self] context in
guard let self else { return }

3
ElementX/Sources/FlowCoordinators/RoomFlowCoordinator.swift
View File

@ -95,7 +95,7 @@ class RoomFlowCoordinator: FlowCoordinatorProtocol {
// MARK: - Private
// swiftlint:disable:next cyclomatic_complexity function_body_length
// swiftlint:disable:next function_body_length
private func setupStateMachine() {
stateMachine.addRouteMapping { event, fromState, _ in
switch (event, fromState) {
@ -258,7 +258,6 @@ class RoomFlowCoordinator: FlowCoordinatorProtocol {
}
}
// swiftlint:disable:next cyclomatic_complexity function_body_length
private func asyncPresentRoom(_ roomID: String, animated: Bool, destinationRoomProxy: RoomProxyProtocol? = nil) async {
if let roomProxy, roomProxy.id == roomID {
navigationStackCoordinator.popToRoot()

2
ElementX/Sources/FlowCoordinators/UserSessionFlowCoordinator.swift
View File

@ -135,7 +135,6 @@ class UserSessionFlowCoordinator: FlowCoordinatorProtocol {
// MARK: - Private
// swiftlint:disable:next cyclomatic_complexity function_body_length
private func setupStateMachine() {
stateMachine.addTransitionHandler { [weak self] context in
guard let self else { return }
@ -241,7 +240,6 @@ class UserSessionFlowCoordinator: FlowCoordinatorProtocol {
}
}
// swiftlint:disable:next cyclomatic_complexity
private func presentHomeScreen() {
let parameters = HomeScreenCoordinatorParameters(userSession: userSession,
attributedStringBuilder: AttributedStringBuilder(permalinkBaseURL: ServiceLocator.shared.settings.permalinkBaseURL),

1
ElementX/Sources/FlowCoordinators/UserSessionFlowCoordinatorStateMachine.swift
View File

@ -114,7 +114,6 @@ class UserSessionFlowCoordinatorStateMachine {
configure()
}
// swiftlint:disable:next cyclomatic_complexity
private func configure() {
stateMachine.addRoutes(event: .start, transitions: [.initial => .roomList(selectedRoomID: nil)])
stateMachine.addRoutes(event: .startWithMigration, transitions: [.initial => .migration])

1
ElementX/Sources/Other/Extensions/UNNotificationContent.swift
View File

@ -101,7 +101,6 @@ extension UNMutableNotificationContent {
return self
}
// swiftlint:disable:next function_body_length
func addSenderIcon(using mediaProvider: MediaProviderProtocol?,
senderID: String,
senderName: String,

2
ElementX/Sources/Screens/HomeScreen/HomeScreenViewModel.swift
View File

@ -34,7 +34,6 @@ class HomeScreenViewModel: HomeScreenViewModelType, HomeScreenViewModelProtocol
var callback: ((HomeScreenViewModelAction) -> Void)?
// swiftlint:disable:next function_body_length cyclomatic_complexity
init(userSession: UserSessionProtocol,
attributedStringBuilder: AttributedStringBuilderProtocol,
selectedRoomPublisher: CurrentValuePublisher<String?, Never>,
@ -156,7 +155,6 @@ class HomeScreenViewModel: HomeScreenViewModelType, HomeScreenViewModelProtocol
// MARK: - Public
// swiftlint:disable:next cyclomatic_complexity
override func process(viewAction: HomeScreenViewAction) {
switch viewAction {
case .selectRoom(let roomIdentifier):

1
ElementX/Sources/Screens/RoomDetailsScreen/RoomDetailsScreenViewModel.swift
View File

@ -69,7 +69,6 @@ class RoomDetailsScreenViewModel: RoomDetailsScreenViewModelType, RoomDetailsScr
// MARK: - Public
// swiftlint:disable:next cyclomatic_complexity
override func process(viewAction: RoomDetailsScreenViewAction) {
switch viewAction {
case .processTapPeople:

1
ElementX/Sources/Screens/RoomScreen/RoomScreenCoordinator.swift
View File

@ -59,7 +59,6 @@ final class RoomScreenCoordinator: CoordinatorProtocol {
// MARK: - Public
// swiftlint:disable:next cyclomatic_complexity
func start() {
viewModel.callback = { [weak self] action in
guard let self else { return }

2
ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift
View File

@ -81,7 +81,6 @@ class RoomScreenViewModel: RoomScreenViewModelType, RoomScreenViewModelProtocol
var callback: ((RoomScreenViewModelAction) -> Void)?
// swiftlint:disable:next cyclomatic_complexity function_body_length
override func process(viewAction: RoomScreenViewAction) {
switch viewAction {
case .displayRoomDetails:
@ -539,7 +538,6 @@ class RoomScreenViewModel: RoomScreenViewModelType, RoomScreenViewModelProtocol
item.isOutgoing || (canCurrentUserRedact && !roomProxy.isDirect)
}
// swiftlint:disable:next cyclomatic_complexity function_body_length
private func processTimelineItemMenuAction(_ action: TimelineItemMenuAction, itemID: TimelineItemIdentifier) {
guard let timelineItem = timelineController.timelineItems.firstUsingStableID(itemID),
let eventTimelineItem = timelineItem as? EventBasedTimelineItemProtocol else {

2
ElementX/Sources/Screens/RoomScreen/View/Style/LongPressWithFeedback.swift
View File

@ -33,7 +33,7 @@ struct LongPressWithFeedback: ViewModifier {
.animation(isLongPressing ? .spring(response: 0.5).delay(0.1) : .spring(response: 0.5),
value: isLongPressing)
// The minimum duration here doesn't actually invoke the perform block when elapsed (thus
// the implementation bellow) but it does cancel other system gestures e.g. swipe to reply
// the implementation below) but it does cancel other system gestures e.g. swipe to reply
.onLongPressGesture(minimumDuration: 0.25) { } onPressingChanged: { isPressing in
isLongPressing = isPressing

1
ElementX/Sources/Screens/SessionVerificationScreen/SessionVerificationScreenStateMachine.swift
View File

@ -83,7 +83,6 @@ class SessionVerificationScreenStateMachine {
configure()
}
// swiftlint:disable:next cyclomatic_complexity
private func configure() {
stateMachine.addRoutes(event: .requestVerification, transitions: [.initial => .requestingVerification])
stateMachine.addRoutes(event: .didAcceptVerificationRequest, transitions: [.requestingVerification => .verificationRequestAccepted])

1
ElementX/Sources/Services/BugReport/BugReportService.swift
View File

@ -101,7 +101,6 @@ class BugReportService: NSObject, BugReportServiceProtocol {
SentrySDK.crash()
}
// swiftlint:disable:next function_body_length cyclomatic_complexity
func submitBugReport(_ bugReport: BugReport,
progressListener: CurrentValueSubject<Double, Never>) async -> Result<SubmitBugReportResponse, BugReportServiceError> {
var params = [

1
ElementX/Sources/Services/Room/RoomSummary/RoomEventStringBuilder.swift
View File

@ -23,7 +23,6 @@ struct RoomEventStringBuilder {
self.stateEventStringBuilder = stateEventStringBuilder
}
// swiftlint:disable:next cyclomatic_complexity
func buildAttributedString(for eventItemProxy: EventTimelineItemProxy) -> AttributedString? {
let sender = eventItemProxy.sender
let isOutgoing = eventItemProxy.isOwn

1
ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProvider.swift
View File

@ -206,7 +206,6 @@ class RoomSummaryProvider: RoomSummaryProviderProtocol {
}
}
// swiftlint:disable:next cyclomatic_complexity function_body_length
private func buildDiff(from diff: RoomListEntriesUpdate, on rooms: [RoomSummary]) -> CollectionDifference<RoomSummary>? {
var changes = [CollectionDifference<RoomSummary>.Change]()

2
ElementX/Sources/Services/Timeline/RoomTimelineProvider.swift
View File

@ -89,7 +89,7 @@ class RoomTimelineProvider: RoomTimelineProviderProtocol {
MXLog.verbose("Finished applying diffs, current items (\(itemProxies.count)) : \(itemProxies.map(\.debugIdentifier))")
}
// swiftlint:disable:next cyclomatic_complexity function_body_length
// swiftlint:disable:next cyclomatic_complexity
private func buildDiff(from diff: TimelineDiff, on itemProxies: [TimelineItemProxy]) -> CollectionDifference<TimelineItemProxy>? {
var changes = [CollectionDifference<TimelineItemProxy>.Change]()

4
ElementX/Sources/Services/Timeline/TimelineItems/RoomStateEventStringBuilder.swift
View File

@ -20,7 +20,6 @@ import UIKit
struct RoomStateEventStringBuilder {
let userID: String
// swiftlint:disable:next cyclomatic_complexity
func buildString(for change: MembershipChange?, member: String, sender: TimelineItemSender, isOutgoing: Bool) -> String? {
guard let change else {
MXLog.verbose("Filtering timeline item for membership change that is nil")
@ -76,7 +75,7 @@ struct RoomStateEventStringBuilder {
}
}
// swiftlint:disable:next cyclomatic_complexity function_parameter_count
// swiftlint:disable:next function_parameter_count
func buildProfileChangeString(displayName: String?, previousDisplayName: String?,
avatarURLString: String?, previousAvatarURLString: String?,
member: String, memberIsYou: Bool) -> String? {
@ -122,7 +121,6 @@ struct RoomStateEventStringBuilder {
}
}
// swiftlint:disable:next cyclomatic_complexity function_body_length
func buildString(for state: OtherState, stateKey: String?, sender: TimelineItemSender, isOutgoing: Bool) -> String? {
let senderName = sender.displayName ?? sender.id

2
ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemFactory.swift
View File

@ -36,7 +36,6 @@ struct RoomTimelineItemFactory: RoomTimelineItemFactoryProtocol {
self.stateEventStringBuilder = stateEventStringBuilder
}
// swiftlint:disable:next cyclomatic_complexity
func buildTimelineItem(for eventItemProxy: EventTimelineItemProxy) -> RoomTimelineItemProtocol? {
let isOutgoing = eventItemProxy.isOwn
@ -543,7 +542,6 @@ struct RoomTimelineItemFactory: RoomTimelineItemFactoryProtocol {
// MARK: - Reply details
// swiftlint:disable:next cyclomatic_complexity
private func buildReplyToDetailsFrom(details: InReplyToDetails?) -> TimelineItemReplyDetails? {
guard let details else { return nil }

1
ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemViewState.swift
View File

@ -70,7 +70,6 @@ enum RoomTimelineItemType: Equatable {
case location(LocationRoomTimelineItem)
case poll(PollRoomTimelineItem)
// swiftlint:disable:next cyclomatic_complexity
init(item: RoomTimelineItemProtocol) {
switch item {
case let item as TextRoomTimelineItem:

1
UnitTests/Sources/LoggingTests.swift
View File

@ -248,7 +248,6 @@ class LoggingTests: XCTestCase {
XCTAssertFalse(content.contains(lastMessage))
}
// swiftlint:disable:next function_body_length
func testTimelineContentIsRedacted() throws {
// Given timeline items that contain text
let textAttributedString = "TextAttributed"